From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41907)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iz7SE-0007O0-Ve
 for guix-patches@gnu.org; Tue, 04 Feb 2020 18:18:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iz7SE-0004bA-0j
 for guix-patches@gnu.org; Tue, 04 Feb 2020 18:18:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:38944)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iz7SD-0004Zu-Sw
 for guix-patches@gnu.org; Tue, 04 Feb 2020 18:18:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iz7SD-00074v-N9
 for guix-patches@gnu.org; Tue, 04 Feb 2020 18:18:01 -0500
Subject: [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to
 cargo-inputs.
Resent-Message-ID: <handler.39261.B39261.158085826827187@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200124103843.29807-1-efraim@flashner.co.il>
Date: Wed, 05 Feb 2020 00:17:36 +0100
In-Reply-To: <20200124103843.29807-1-efraim@flashner.co.il> (Efraim Flashner's
 message of "Fri, 24 Jan 2020 12:38:43 +0200")
Message-ID: <87imkmt01b.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 39261@debbugs.gnu.org

Hello!

Nitpick: for the subject line, I=E2=80=99d write:

  import: crate: Move build dependencies to cargo-inputs.

Efraim Flashner <efraim@flashner.co.il> skribis:

> * guix/import/crate.scm (crate->guix-package): Add definition for
> 'dev-dependency?' and 'build-dependency?'. Adjust dep-crates to take
> normal- and build- dependencies.

[...]

> +  (define (dev-dependency? dependency)
> +    (eq? (crate-dependency-kind dependency) 'dev))

Nitpick2: I=E2=80=99d recommend =E2=80=98development-dependency?=E2=80=99 a=
s per the style
guidelines.  :-)

Anyhow, LGTM!

Thanks,
Ludo=E2=80=99.