From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36355) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOb2l-0001Rr-1p for guix-patches@gnu.org; Wed, 15 Apr 2020 01:57:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOb2k-0004fz-1Y for guix-patches@gnu.org; Wed, 15 Apr 2020 01:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOb2j-0004ft-Vb for guix-patches@gnu.org; Wed, 15 Apr 2020 01:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOb2j-0001ZE-Vv for guix-patches@gnu.org; Wed, 15 Apr 2020 01:57:01 -0400 Subject: [bug#40426] [PATCH] Add g-golf Resent-Message-ID: References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87eesq6iqq.fsf@cbaines.net> From: Mike Rosset Message-ID: <87imi1z46t.fsf@gmail.com> In-reply-to: <87eesq6iqq.fsf@cbaines.net> Date: Tue, 14 Apr 2020 22:56:24 -0700 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40426@debbugs.gnu.org Cc: D0dyBo0D0dyBo0@protonmail.com Christopher Baines writes: > Vitaliy Shatrov via Guix-patches via writes: > > Does g-golf work with Guile 3 yet? If not, that's OK. > Hello Christopher, thanks for looking at this. I did quick look at seeing if g-golf would work with guile 3.0. But I ran into some issue with core module bindings. Since g-golf very much WIP and like wise Nomad which is my primary use for g-golf is also WIP. I've kept strictly to guile 2.2 for now to maintain a little extra stability. I'll follow up on it when both nomad a g-golf are more stable. > > I'd remove the #:tests? argument given the default value of #t is fine. > Not a problem either myself or Vitality will add a follow up patch. This was orphaned since we just recently got tests working. > I don't quite follow this GUILE_GGOLF_UNINSTALLED environment > variable. Why not just use the absolute filename for the so file > (without the extension I think)? The problem here is that libg-golf is needed both at compile time and runtime. So it can not be substituted say after the unpack stage. So this just checks if GUILE_GGOLF_UNINSTALLED is set. Then it will use libg-golf with normal dynamic-link search paths. Other wise it uses the full store path. I had discussed this scenario with the g-golf author, his recommendation was to use this approach it's the same one used for the guile-cv declaration. He's the author of guile-cv as well. > Also, maybe delete the strip phase, as I don't think that does anything > apart from producing a load of warnings. > I think the strip phase strips dynamic elf libraries as well? I don't think it would hurt here to keep it for libg-golf at least? Would you also be able to look at bug#40512 Christopher? That one is a trivial review just some upstream bug fixes for Emacsy and a hash bump in the package declaration. Technically not related to the patch. But eventually I'll need both of these when I release the next version of nomad. Regards, Mike