unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Boris A. Dekshteyn" <boris.dekshteyn@gmail.com>,
	41170-done@debbugs.gnu.org
Cc: "Boris A. Dekshteyn" <boris.dekshteyn@gmail.com>
Subject: bug#41170: [PATCH] gnu: freecad: Fix build with python-3.8
Date: Sun, 10 May 2020 23:07:35 +0200	[thread overview]
Message-ID: <87imh31otk.fsf@devup.no> (raw)
In-Reply-To: <20200510102318.23016-1-boris.dekshteyn@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

"Boris A. Dekshteyn" <boris.dekshteyn@gmail.com> writes:

> * gnu/packages/engineering.scm (freecad): Fix build with python-3.8

Thank you!

[...]

> +       (modules '((guix build utils)))
> +       (snippet
> +        '(begin
> +           ;; https://tracker.freecadweb.org/view.php?id=4143
> +           (substitute* "src/Base/swigpyrun.inl"
> +             (("PyObject \\*modules = interp->modules;")
> +               "PyObject *modules = PyEval_GetBuiltins();")) #t))

I gave a little more context in the comment, moved the #t on a line of
its own, and fixed the indentation.  I also edited the commit message
slightly.

Pushed as 72099cb0f20e87807f29b5a11a584ab7c66297ef.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-05-10 21:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 10:23 [bug#41170] [PATCH] gnu: freecad: Fix build with python-3.8 Boris A. Dekshteyn
2020-05-10 21:07 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imh31otk.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=41170-done@debbugs.gnu.org \
    --cc=boris.dekshteyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).