From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iNsSL1MF/V5/dgAA0tVLHw (envelope-from ) for ; Wed, 01 Jul 2020 21:51:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uB31KlMF/V6nHAAA1q6Kng (envelope-from ) for ; Wed, 01 Jul 2020 21:51:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CE9B9402D1 for ; Wed, 1 Jul 2020 21:51:14 +0000 (UTC) Received: from localhost ([::1]:57434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqkdL-00040E-SR for larch@yhetil.org; Wed, 01 Jul 2020 17:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqkdC-0003tB-Si for guix-patches@gnu.org; Wed, 01 Jul 2020 17:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqkdC-00073P-I1 for guix-patches@gnu.org; Wed, 01 Jul 2020 17:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqkdC-0005IB-H9 for guix-patches@gnu.org; Wed, 01 Jul 2020 17:51:02 -0400 Subject: bug#42048: [PATCH 6/6] services: provenance: Save channel introductions. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 01 Jul 2020 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42048 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 42048-done@debbugs.gnu.org Mail-Followup-To: 42048@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 42048-done@debbugs.gnu.org id=D42048.159364023320305 (code D ref 42048); Wed, 01 Jul 2020 21:51:02 +0000 Received: (at 42048-done) by debbugs.gnu.org; 1 Jul 2020 21:50:33 +0000 Received: from localhost ([127.0.0.1]:53850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqkcj-0005HQ-60 for submit@debbugs.gnu.org; Wed, 01 Jul 2020 17:50:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqkch-0005HE-1s for 42048-done@debbugs.gnu.org; Wed, 01 Jul 2020 17:50:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47243) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqkcb-0006rM-6N; Wed, 01 Jul 2020 17:50:25 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51322 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jqkca-0000Ic-EN; Wed, 01 Jul 2020 17:50:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200625211605.29316-1-ludo@gnu.org> <20200625211605.29316-6-ludo@gnu.org> <87v9j8mtx9.fsf@elephly.net> <87imf847sr.fsf@gnu.org> <87366bmnhb.fsf@elephly.net> Date: Wed, 01 Jul 2020 23:50:21 +0200 In-Reply-To: <87366bmnhb.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 01 Jul 2020 14:25:04 +0200") Message-ID: <87imf6ykf6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: nujZrR64EEJd Hi, Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >> So yes, I suppose we would need to extend the =E2=80=98.guix-channel=E2= =80=99 format for >> dependencies. Luckily it should be quite simply because that format is >> extensible; older Guix versions would ignore the =E2=80=98introduction= =E2=80=99 field. >> It would look something like this: >> >> (channel >> (version 0) >> (dependencies >> (channel >> (name some-collection) >> (url "https://example.org/first-collection.git") >> (introduction (channel-introduction >> (version 0) >> (commit "=E2=80=A6") >> (signer "=E2=80=A6")))) >> (channel >> (name some-other-collection) >> (url "https://example.org/second-collection.git") >> (branch "testing")))) ;not an authenticated channel >> >> It does mean that a channel can indirectly trick you into turning off >> authentication for a dependent channel. But I think that=E2=80=99s with= in the >> expectations for channels: when you choose a channel, you trust it >> enough to run its code. >> >> WDYT? > > This sounds reasonable. I agree that you=E2=80=99ve got to trust the cha= nnel > authors anyway, so allowing them to provide the introduction is fair. I went ahead and did that: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Dd774c7b1218a3cc20= 079b19812da119f9ed26b54 Let me know what you think! The whole series is now pushed: d774c7b121 channels: Dependencies listed in '.guix-channel' can have an i= ntroduction. 884df77640 channels: Properly diagnose test failure. eb5cf39e66 services: provenance: Save channel introductions. 6d39f0cb77 guix describe: Display channel introductions and add 'channels= -sans-intro'. 471550c28c channels: Save and interpret 'introduction' field in provenanc= e data. 22a9699257 channels: Remove 'signature' from . 8b7d982e6a channels: Make channel introductions public. 6577682a6c channels: Add 'openpgp-fingerprint->bytevector'. Thanks for your feedback, Ludo=E2=80=99.