unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Tanguy Le Carrour <tanguy@bioneland.org>, 42364@debbugs.gnu.org
Cc: Tanguy Le Carrour <tanguy@bioneland.org>
Subject: [bug#42364] [PATCH] gnu: Add python-robber.
Date: Tue, 21 Jul 2020 23:22:29 +0200	[thread overview]
Message-ID: <87imegftre.fsf@gnu.org> (raw)
In-Reply-To: <20200715122832.9196-1-tanguy@bioneland.org>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> * gnu/packages/python-xyz.scm (python-robber): New variable.

Thanks!  As this appears to be a test library, can you move it to
python-check.scm?

[...]
  
> +(define-public python-robber
> +  (package
> +    (name "python-robber")
> +    (version "1.1.5")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "robber" version))
> +              (sha256
> +               (base32
> +                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
> +    (build-system python-build-system)
> +    (arguments '(#:tests? #f))  ; no tests

There appears to be tests in the upstream repository:

  https://github.com/vesln/robber.py/tree/master/tests

Perhaps we should pull that instead of the PyPI release?

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-07-21 21:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 12:28 [bug#42364] [PATCH] gnu: Add python-robber Tanguy Le Carrour
2020-07-21 21:22 ` Marius Bakke [this message]
2020-07-22  8:14   ` Tanguy Le Carrour
2020-07-22  8:14 ` [bug#42364] [PATCH v2] " Tanguy Le Carrour
2020-07-25 15:40   ` Marius Bakke
2020-07-27  8:26     ` Tanguy Le Carrour
2020-07-29 22:23       ` Marius Bakke
2020-07-30  9:40 ` [bug#42364] [PATCH v3] " Tanguy Le Carrour
2020-09-24 15:49   ` bug#42364: " Ludovic Courtès
2020-09-27 13:39     ` [bug#42364] " Tanguy Le Carrour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imegftre.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=42364@debbugs.gnu.org \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).