From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wGw8AIS3T18iJwAA0tVLHw (envelope-from ) for ; Wed, 02 Sep 2020 15:17:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SOmWN4O3T1+TJgAAbx9fmQ (envelope-from ) for ; Wed, 02 Sep 2020 15:17:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5AAC29401CD for ; Wed, 2 Sep 2020 15:17:23 +0000 (UTC) Received: from localhost ([::1]:57072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDUVm-00043v-A9 for larch@yhetil.org; Wed, 02 Sep 2020 11:17:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDUUU-0003Hl-6h for guix-patches@gnu.org; Wed, 02 Sep 2020 11:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDUUT-0000Rz-SD for guix-patches@gnu.org; Wed, 02 Sep 2020 11:16:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDUUT-00047T-Ov for guix-patches@gnu.org; Wed, 02 Sep 2020 11:16:01 -0400 Subject: bug#42849: [PATCH 3/3] installer: Run the installation inside a container. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 02 Sep 2020 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42849 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42849-done@debbugs.gnu.org Mail-Followup-To: 42849@debbugs.gnu.org, othacehe@gnu.org, othacehe@gnu.org Received: via spool by 42849-done@debbugs.gnu.org id=D42849.159905974114646 (code D ref 42849); Wed, 02 Sep 2020 15:16:01 +0000 Received: (at 42849-done) by debbugs.gnu.org; 2 Sep 2020 15:15:41 +0000 Received: from localhost ([127.0.0.1]:60373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDUU9-0003nd-Cq for submit@debbugs.gnu.org; Wed, 02 Sep 2020 11:15:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDUU7-0003h8-Jp for 42849-done@debbugs.gnu.org; Wed, 02 Sep 2020 11:15:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46804) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDUU1-0000FC-En; Wed, 02 Sep 2020 11:15:34 -0400 Received: from [2a01:e0a:19b:d9a0:9d9d:97cc:d92a:8ac0] (port=57836 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kDUTz-0006tE-QI; Wed, 02 Sep 2020 11:15:32 -0400 From: Mathieu Othacehe References: <20200813123419.263639-1-othacehe@gnu.org> <20200813123419.263639-3-othacehe@gnu.org> <87eennhnpz.fsf@gnu.org> <87a6ybiab6.fsf@gnu.org> <87k0xdanng.fsf@gnu.org> Date: Wed, 02 Sep 2020 17:15:30 +0200 In-Reply-To: <87k0xdanng.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 01 Sep 2020 10:48:03 +0200") Message-ID: <87imcwtdkd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7fotSnnCmBXl Hey Ludo, > So perhaps we can settle on the solution you sent, but let=E2=80=99s see = if we > can move complexity out of sight. For example, if we can arrange to > have a =E2=80=98fork+exec-command/container=E2=80=99 procedure that can b= e passed the > PID of a namespace, such that the =E2=80=98start=E2=80=99 method of guix-= daemon is just > a few more lines its current definition, I=E2=80=99ll be happy. > > How does that sound? Sounds fine! I added a "fork+exec-command/container" in (gnu build shepherd) module, that uses "container-excursion" to enter the namespaces of the process passed as argument. I also took your other remarks into account and pushed this serie. Thanks a lot for diving into this harsh stuff :). Locally, the installer tests behave fine, but I'll monitor the CI to see how it goes. Now, the only installation test failure I'm aware of is https://issues.guix.gnu.org/41948. The good news, is that I have a Guile patch that seem to solve it[1]. Thanks, Mathieu [1]: https://lists.gnu.org/archive/html/bug-guile/2020-08/msg00023.html