From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eIMxBUJUhV91TQAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 07:16:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id HCQGAUJUhV/zbQAA1q6Kng (envelope-from ) for ; Tue, 13 Oct 2020 07:16:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90D7094014A for ; Tue, 13 Oct 2020 07:16:17 +0000 (UTC) Received: from localhost ([::1]:59870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSEXg-0002kS-FR for larch@yhetil.org; Tue, 13 Oct 2020 03:16:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSEXS-0002jv-Mq for guix-patches@gnu.org; Tue, 13 Oct 2020 03:16:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSEXS-0002zi-Dr for guix-patches@gnu.org; Tue, 13 Oct 2020 03:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSEXS-0000Zp-9x for guix-patches@gnu.org; Tue, 13 Oct 2020 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43930] gnu: Add emacs-graphql-mode. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Oct 2020 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43930 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: John Soo Cc: 43930@debbugs.gnu.org Received: via spool by 43930-submit@debbugs.gnu.org id=B43930.16025733482190 (code B ref 43930); Tue, 13 Oct 2020 07:16:02 +0000 Received: (at 43930) by debbugs.gnu.org; 13 Oct 2020 07:15:48 +0000 Received: from localhost ([127.0.0.1]:44986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSEXE-0000ZG-7a for submit@debbugs.gnu.org; Tue, 13 Oct 2020 03:15:48 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:54501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSEXA-0000Yy-SK for 43930@debbugs.gnu.org; Tue, 13 Oct 2020 03:15:47 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id EC9E910000B; Tue, 13 Oct 2020 07:15:36 +0000 (UTC) From: Nicolas Goaziou References: <87imbgofzz.fsf@asu.edu> Date: Tue, 13 Oct 2020 09:15:36 +0200 In-Reply-To: <87imbgofzz.fsf@asu.edu> (John Soo's message of "Sun, 11 Oct 2020 09:59:44 -0700") Message-ID: <87imbe61gn.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: LZTcajIGgYCu Hello, John Soo writes: > I've been writing some graphql recently and graphql-mode has been > invaluable. Thank you. Some comments follow. > +(define-public emacs-graphql-mode > + (let ((commit "9bed568ec86242dbe30bdbab324aa0eb2cd9bf08") Could you add a comment explaining why you don't use a tagged commit (in this case, there is none)? > + (revision "1")) > + (package > + (name "emacs-graphql-mode") > + (version commit) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/davazp/graphql-mode") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4")))) Nitpick: please move the string on the same line as `base32'. > + (build-system emacs-build-system) > + (home-page > + "https://github.com/davazp/graphql-mode") Nitpick: please move the string on the same line as `home-page'. > + (synopsis "Emacs mode to edit GraphQL schema and queries") > + (description > + "This package provides an Emacs mode for editing graphql queries and > +schemas.") I suggest to expound the description a bit. For example, using commentary section of the library, it could be something along the lines of: This package implements a major mode to edit GraphQL schemas and query. The basic functionality includes syntax highlight and indentation. Additionally, it is able to send GraphQL queries to an end-point URL. Files with the @file{.graphql} and @file{.gql} extensions are automatically opened with this mode. Could you send an updated patch? Regards, -- Nicolas Goaziou