From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QYi5D16piF8RLAAA0tVLHw (envelope-from ) for ; Thu, 15 Oct 2020 19:56:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gJgsC16piF+JCgAAbx9fmQ (envelope-from ) for ; Thu, 15 Oct 2020 19:56:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D8F39401BD for ; Thu, 15 Oct 2020 19:56:13 +0000 (UTC) Received: from localhost ([::1]:58354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT9MC-0008CS-AG for larch@yhetil.org; Thu, 15 Oct 2020 15:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT9M2-00086B-VX for guix-patches@gnu.org; Thu, 15 Oct 2020 15:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT9M2-000893-KZ for guix-patches@gnu.org; Thu, 15 Oct 2020 15:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kT9M2-0001Jk-Kg for guix-patches@gnu.org; Thu, 15 Oct 2020 15:56:02 -0400 Subject: bug#44008: [PATCH] gnu: Add tsukundere. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 15 Oct 2020 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44008 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 44008-done@debbugs.gnu.org Mail-Followup-To: 44008@debbugs.gnu.org, mail@cbaines.net, leo.prikler@student.tugraz.at Received: via spool by 44008-done@debbugs.gnu.org id=D44008.16027917304993 (code D ref 44008); Thu, 15 Oct 2020 19:56:02 +0000 Received: (at 44008-done) by debbugs.gnu.org; 15 Oct 2020 19:55:30 +0000 Received: from localhost ([127.0.0.1]:56644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT9LW-0001IT-8D for submit@debbugs.gnu.org; Thu, 15 Oct 2020 15:55:30 -0400 Received: from mira.cbaines.net ([212.71.252.8]:60762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT9LU-0001IK-0y for 44008-done@debbugs.gnu.org; Thu, 15 Oct 2020 15:55:28 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 1B3EC27BBEC; Thu, 15 Oct 2020 20:55:27 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 86fd3492; Thu, 15 Oct 2020 19:55:24 +0000 (UTC) References: <20201015102040.12598-1-leo.prikler@student.tugraz.at> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201015102040.12598-1-leo.prikler@student.tugraz.at> Date: Thu, 15 Oct 2020 20:55:22 +0100 Message-ID: <87imbbi7rp.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: VRJC8GCUpanU --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > * gnu/packages/game-development.scm (tsukundere): New variable. > --- > gnu/packages/game-development.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm > index 061dc13f69..0f2734e3c4 100644 > --- a/gnu/packages/game-development.scm > +++ b/gnu/packages/game-development.scm > @@ -2476,3 +2476,31 @@ fully dynamic omnidirectional shadows, global illu= mination, HDR lighting, > deferred shading, morphological / temporal / multisample anti-aliasing, = and > much more.") > (license license:zlib)))) > + > +(define-public tsukundere > + (package > + (name "tsukundere") > + (version "0.2.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/leoprikler/tsukundere") > + (commit version))) > + (sha256 > + (base32 > + "0qmqch8hh7vsa8qaz853vwbkz0krb106955dnz8dsl7skbm5jpn6"))= )) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf-wrapper) > + ("automake" ,automake) > + ("guile" ,guile-3.0) > + ("pkg-config" ,pkg-config))) > + (propagated-inputs > + `(("guile-sdl2" ,guile3.0-sdl2))) > + (home-page "https://gitlab.com/leoprikler/tsukundere") > + (synopsis "Visual novel engine") > + (description "Tsukundere is a game engine geared heavily towards the > +development of visual novels, written on top of Guile-SDL2. It is still > +experimental and at the time of writing contains little more than the Gu= ile > +modules, that make up its runtime.") > + (license license:lgpl3+))) Thanks, I made a couple of changes detailed below, but pushed the tweaked patch to master as 3e072a59be55107bdcde4d1eabe2c857a254ebcc. Guix lint said "the source file name should contain the package name", this is because the source file is a Git repository, and the default name for those doesn't contain the package name: =E2=86=92 ./pre-inst-env guix build -S tsukundere /gnu/store/65xkcflmr0lwk1jzgrac1n28s9as65xn-git-checkout It's useful to not have lots of ...-git-checkout directories in the store, as it makes it harder to know what they are. This can be avoided by adding a (file-name (git-file-name name version)) bit in to the origin record. Also, adding new packages to the bottom of modules can be problematic, if others do similarly, because it makes applying the patches awkward. For that reason, if you don't especially want the package to go at the bottom of the module, slot it in somewhere else. I moved the tsukundere package up to beneath the tiled package, as that's somewhat alphabetically ordered. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+IqSpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfIjA/+JBAJmImeskBItMIuTW8VoBKEC03o9qw9 wT/wmCmsMsm/0KkI0Oz0ebypaoJX0keTQ+CqpvHXjWnrkxajshdYHntT6lgkOt8j jU4LVNPNLKDmUA/LuSou/dXc+UmQqEOFcTEuiInmLuR+Uow7A9nyd598LtLkQEYU /VFHf03JXu7Bbv9zqAHyAGuTYS+cmavX3A9sMy7xnaoeR7GVMo5EzFM1Sr21L/T1 T8WRS1i6lLhU4CPecTdMXDjENfp3LPrfi8+g+n4DndJQ1CyCxsYUgyx6zIXks6Da b7exhfnvmgUOx5azkHowfVGPnGacPCWOrV+/3oaX9/V/FUSPuoYFoFwzb+phtYJy 8UKQGb2jBgO6JxQnAS9rb9O0/BttMTs1RLTnSHvv4ZJVi6KYj+1xpoG1cnMCOI2y b+r7f6TgbS5Rxc80rewf2+VEZ29Wo9oo3IMyrfaWLP/Sc8y0kRsT6bndPIN5+al4 PE6nUSBOluAkayaqMkb1IlHqNdMQfoNJLLe3arlkuTe9EUpwG3pb7uFD+uN54YWy VZulI9mOqAm9REd2tLAIkswSQ3P0YuSK2WH4lBh2Q4+YgOQiQgG5CDSASHUpQLWk FqHq/hFkZ5rVZBqP9v8CXsJw3dPIrPsIWl7b8V3oOYRnn0IVDg0VPFLNfUz0bF7m Muyg1LwMVZ4= =Euww -----END PGP SIGNATURE----- --=-=-=--