unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 44008-done@debbugs.gnu.org
Subject: bug#44008: [PATCH] gnu: Add tsukundere.
Date: Thu, 15 Oct 2020 20:55:22 +0100
Message-ID: <87imbbi7rp.fsf@cbaines.net> (raw)
In-Reply-To: <20201015102040.12598-1-leo.prikler@student.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 2876 bytes --]


Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/game-development.scm (tsukundere): New variable.
> ---
>  gnu/packages/game-development.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> index 061dc13f69..0f2734e3c4 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -2476,3 +2476,31 @@ fully dynamic omnidirectional shadows, global illumination, HDR lighting,
>  deferred shading, morphological / temporal / multisample anti-aliasing, and
>  much more.")
>        (license license:zlib))))
> +
> +(define-public tsukundere
> +  (package
> +    (name "tsukundere")
> +    (version "0.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.com/leoprikler/tsukundere")
> +                    (commit version)))
> +              (sha256
> +               (base32
> +                "0qmqch8hh7vsa8qaz853vwbkz0krb106955dnz8dsl7skbm5jpn6"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf-wrapper)
> +       ("automake" ,automake)
> +       ("guile" ,guile-3.0)
> +       ("pkg-config" ,pkg-config)))
> +    (propagated-inputs
> +     `(("guile-sdl2" ,guile3.0-sdl2)))
> +    (home-page "https://gitlab.com/leoprikler/tsukundere")
> +    (synopsis "Visual novel engine")
> +    (description "Tsukundere is a game engine geared heavily towards the
> +development of visual novels, written on top of Guile-SDL2.  It is still
> +experimental and at the time of writing contains little more than the Guile
> +modules, that make up its runtime.")
> +    (license license:lgpl3+)))

Thanks, I made a couple of changes detailed below, but pushed the
tweaked patch to master as 3e072a59be55107bdcde4d1eabe2c857a254ebcc.

Guix lint said "the source file name should contain the package name",
this is because the source file is a Git repository, and the default
name for those doesn't contain the package name:

→ ./pre-inst-env guix build -S tsukundere
/gnu/store/65xkcflmr0lwk1jzgrac1n28s9as65xn-git-checkout

It's useful to not have lots of ...-git-checkout directories in the
store, as it makes it harder to know what they are. This can be avoided
by adding a (file-name (git-file-name name version)) bit in to the
origin record.

Also, adding new packages to the bottom of modules can be problematic,
if others do similarly, because it makes applying the patches
awkward. For that reason, if you don't especially want the package to go
at the bottom of the module, slot it in somewhere else. I moved the
tsukundere package up to beneath the tiled package, as that's somewhat
alphabetically ordered.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2020-10-15 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 10:20 [bug#44008] " Leo Prikler
2020-10-15 19:55 ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imbbi7rp.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44008-done@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git