From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WF/DKhriiF8QbAAA0tVLHw (envelope-from ) for ; Thu, 15 Oct 2020 23:58:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id pxyPJhriiF8RcgAA1q6Kng (envelope-from ) for ; Thu, 15 Oct 2020 23:58:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68C389402A7 for ; Thu, 15 Oct 2020 23:58:17 +0000 (UTC) Received: from localhost ([::1]:51332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTD8R-0002QI-TU for larch@yhetil.org; Thu, 15 Oct 2020 19:58:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTD8D-0002Pz-TB for guix-patches@gnu.org; Thu, 15 Oct 2020 19:58:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTD8D-0004T6-K9 for guix-patches@gnu.org; Thu, 15 Oct 2020 19:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTD8D-00037u-It for guix-patches@gnu.org; Thu, 15 Oct 2020 19:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH] gnu: Add libebur128. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Oct 2020 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 43883@debbugs.gnu.org Received: via spool by 43883-submit@debbugs.gnu.org id=B43883.160280624511970 (code B ref 43883); Thu, 15 Oct 2020 23:58:01 +0000 Received: (at 43883) by debbugs.gnu.org; 15 Oct 2020 23:57:25 +0000 Received: from localhost ([127.0.0.1]:57021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTD7d-000370-HS for submit@debbugs.gnu.org; Thu, 15 Oct 2020 19:57:25 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTD7b-00036n-Pq for 43883@debbugs.gnu.org; Thu, 15 Oct 2020 19:57:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 840862400FB for <43883@debbugs.gnu.org>; Fri, 16 Oct 2020 01:57:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1602806237; bh=gZaeR/jPLL1Gbrvvl7TLgPy1LGaoKRKuBkqJWKLW8jU=; h=From:To:Cc:Subject:Date:From; b=XQIb5ZEpJLmSC6wyiQC+TMARkEf3o/lElW7SfdnStjWdK83RP8gXAmkWAKA/yYO6q eJQCMUeLMqHb/KWxqtZrMra865yf8vrBkpIdGCI6GGTub7P6ncjkzuNUDmSfoWoQ9l +iHZFzLU5Uw9NT/phIi7/Q+WpNY7dt3QZNgA73qjvr7Zr+Nk8ZjYxGGh8Jpinq7t0H aeMdH5a6YguUDoHhMyUptXOw1eE6Hw0bQzvHtGpY7fIsiH0gnntZzO+5Qbulf1FsX3 IV1i+zN2MJMsR1nLLSIKATYpXN5vskKqYt0Q28i7MjSdMdcjr4u3GVgxBCU0I09htg Q5CJhr7Ti600w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CC5mq5HSTz9rxM; Fri, 16 Oct 2020 01:57:15 +0200 (CEST) References: <20201009151256.7949-1-monego@posteo.net> <87imbdrfo7.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Vinicius Monego In-reply-to: <87imbdrfo7.fsf@gnu.org> Date: Thu, 15 Oct 2020 20:56:44 -0300 Message-ID: <87imbb11s3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=XQIb5ZEp; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: QzSwgtYjqv5g Marius Bakke writes: > Vinicius Monego writes: > >> * gnu/packages/audio.scm (libebur128): New variable. > > [...] > >> + (arguments >> + `(;; Tests require .wav files that are not distributed with the code. >> + ;; See https://github.com/jiixyj/libebur128/issues/82. >> + #:tests? #f > > It is easy to provide these data files using an (origin ...) in > native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check > the terms of use first, as the data set is unrelated to this package. > > (I don't really have a strong opinion here, just sayin') > I had a look at the terms (link provided in the issue referenced above) and commercial usage is forbidden, making the audio files nonfree. Also, the zip file weighs 87 MB. >> + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release" > > Note: you can use #:build-type "Release" instead. The default is > "RelWithDebInfo", so it's customary to add a comment when changing it. > Is there a particular reason to not provide debugging information here? Oh, I wasn't aware of #:build-type. Thanks. I remove debugging information to save space. The ideal case is to move it to a separate output as in https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html , but that is something I have yet to take a look at. I will enable it again in the v2 and add a comment about the data.