unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#43883] [PATCH] gnu: Add libebur128.
@ 2020-10-09 15:12 Vinicius Monego
  2020-10-13 21:15 ` Marius Bakke
  2020-10-16 14:21 ` [bug#43883] [PATCH v2] " Vinicius Monego
  0 siblings, 2 replies; 5+ messages in thread
From: Vinicius Monego @ 2020-10-09 15:12 UTC (permalink / raw)
  To: 43883; +Cc: Vinicius Monego

* gnu/packages/audio.scm (libebur128): New variable.
---
 gnu/packages/audio.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0e93a7263e..bd88987e13 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3060,6 +3060,33 @@ that toolkit will work in all hosts that use Suil automatically.
 Suil currently supports every combination of Gtk, Qt, and X11.")
     (license license:isc)))
 
+(define-public libebur128
+  (package
+    (name "libebur128")
+    (version "1.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jiixyj/libebur128")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(;; Tests require .wav files that are not distributed with the code.
+       ;; See https://github.com/jiixyj/libebur128/issues/82.
+       #:tests? #f
+       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
+                           "-DBUILD_STATIC_LIBS=OFF")))
+    (home-page "https://github.com/jiixyj/libebur128")
+    (synopsis "Library implementing the EBU R 128 loudness standard")
+    (description
+     "@code{libebur128} is a C library that implements the EBU R 128 standard
+for loudness normalisation.")
+    (license license:expat)))
+
 (define-public timidity++
   (package
     (name "timidity++")
-- 
2.20.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43883] [PATCH] gnu: Add libebur128.
  2020-10-09 15:12 [bug#43883] [PATCH] gnu: Add libebur128 Vinicius Monego
@ 2020-10-13 21:15 ` Marius Bakke
  2020-10-15 23:56   ` Vinicius Monego
  2020-10-16 14:21 ` [bug#43883] [PATCH v2] " Vinicius Monego
  1 sibling, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2020-10-13 21:15 UTC (permalink / raw)
  To: Vinicius Monego, 43883; +Cc: Vinicius Monego

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/audio.scm (libebur128): New variable.

[...]
  
> +    (arguments
> +     `(;; Tests require .wav files that are not distributed with the code.
> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
> +       #:tests? #f

It is easy to provide these data files using an (origin ...) in
native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
the terms of use first, as the data set is unrelated to this package.

(I don't really have a strong opinion here, just sayin')

> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"

Note: you can use #:build-type "Release" instead.  The default is
"RelWithDebInfo", so it's customary to add a comment when changing it.
Is there a particular reason to not provide debugging information here?

Otherwise the patch LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43883] [PATCH] gnu: Add libebur128.
  2020-10-13 21:15 ` Marius Bakke
@ 2020-10-15 23:56   ` Vinicius Monego
  2020-10-18 21:59     ` bug#43883: " Marius Bakke
  0 siblings, 1 reply; 5+ messages in thread
From: Vinicius Monego @ 2020-10-15 23:56 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 43883


Marius Bakke writes:

> Vinicius Monego <monego@posteo.net> writes:
>
>> * gnu/packages/audio.scm (libebur128): New variable.
>
> [...]
>   
>> +    (arguments
>> +     `(;; Tests require .wav files that are not distributed with the code.
>> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
>> +       #:tests? #f
>
> It is easy to provide these data files using an (origin ...) in
> native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
> the terms of use first, as the data set is unrelated to this package.
>
> (I don't really have a strong opinion here, just sayin')
>

I had a look at the terms (link provided in the issue referenced above)
and commercial usage is forbidden, making the audio files nonfree. Also, the
zip file weighs 87 MB.

>> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>
> Note: you can use #:build-type "Release" instead.  The default is
> "RelWithDebInfo", so it's customary to add a comment when changing it.
> Is there a particular reason to not provide debugging information here?

Oh, I wasn't aware of #:build-type. Thanks.

I remove debugging information to save space. The ideal case is to move
it to a separate output as in

https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html

, but that is something I have yet to take a look at.

I will enable it again in the v2 and add a comment about the data.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#43883] [PATCH v2] gnu: Add libebur128.
  2020-10-09 15:12 [bug#43883] [PATCH] gnu: Add libebur128 Vinicius Monego
  2020-10-13 21:15 ` Marius Bakke
@ 2020-10-16 14:21 ` Vinicius Monego
  1 sibling, 0 replies; 5+ messages in thread
From: Vinicius Monego @ 2020-10-16 14:21 UTC (permalink / raw)
  To: 43883; +Cc: Vinicius Monego

* gnu/packages/audio.scm (libebur128): New variable.
---
Changed comment about why tests are disabled and build with debug information.

 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0e93a7263e..5bdbec40a2 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3060,6 +3060,32 @@ that toolkit will work in all hosts that use Suil automatically.
 Suil currently supports every combination of Gtk, Qt, and X11.")
     (license license:isc)))
 
+(define-public libebur128
+  (package
+    (name "libebur128")
+    (version "1.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jiixyj/libebur128")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(;; Tests require proprietary .wav files. See
+       ;; https://github.com/jiixyj/libebur128/issues/82.
+       #:tests? #f
+       #:configure-flags '("-DBUILD_STATIC_LIBS=OFF")))
+    (home-page "https://github.com/jiixyj/libebur128")
+    (synopsis "Library implementing the EBU R 128 loudness standard")
+    (description
+     "@code{libebur128} is a C library that implements the EBU R 128 standard
+for loudness normalisation.")
+    (license license:expat)))
+
 (define-public timidity++
   (package
     (name "timidity++")
-- 
2.20.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#43883: [PATCH] gnu: Add libebur128.
  2020-10-15 23:56   ` Vinicius Monego
@ 2020-10-18 21:59     ` Marius Bakke
  0 siblings, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2020-10-18 21:59 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 43883-done

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

Vinicius Monego <monego@posteo.net> writes:

> Marius Bakke writes:
>
>> Vinicius Monego <monego@posteo.net> writes:
>>
>>> * gnu/packages/audio.scm (libebur128): New variable.
>>
>> [...]
>>   
>>> +    (arguments
>>> +     `(;; Tests require .wav files that are not distributed with the code.
>>> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
>>> +       #:tests? #f
>>
>> It is easy to provide these data files using an (origin ...) in
>> native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
>> the terms of use first, as the data set is unrelated to this package.
>>
>> (I don't really have a strong opinion here, just sayin')
>>
>
> I had a look at the terms (link provided in the issue referenced above)
> and commercial usage is forbidden, making the audio files nonfree. Also, the
> zip file weighs 87 MB.

Oh, thanks for checking, too bad.

>>> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>>
>> Note: you can use #:build-type "Release" instead.  The default is
>> "RelWithDebInfo", so it's customary to add a comment when changing it.
>> Is there a particular reason to not provide debugging information here?
>
> Oh, I wasn't aware of #:build-type. Thanks.
>
> I remove debugging information to save space. The ideal case is to move
> it to a separate output as in
>
> https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html
>
> , but that is something I have yet to take a look at.
>
> I will enable it again in the v2 and add a comment about the data.

Excellent, applied!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-18 22:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 15:12 [bug#43883] [PATCH] gnu: Add libebur128 Vinicius Monego
2020-10-13 21:15 ` Marius Bakke
2020-10-15 23:56   ` Vinicius Monego
2020-10-18 21:59     ` bug#43883: " Marius Bakke
2020-10-16 14:21 ` [bug#43883] [PATCH v2] " Vinicius Monego

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git