unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Simon South <simon@simonsouth.net>
Cc: 44493-done@debbugs.gnu.org
Subject: bug#44493: [PATCH 0/1] gnu: bitcoin-core: Update to 0.20.1.
Date: Wed, 18 Nov 2020 08:48:25 +0000	[thread overview]
Message-ID: <87ima3kq3q.fsf@cbaines.net> (raw)
In-Reply-To: <cover.1604701819.git.simon@simonsouth.net>

[-- Attachment #1: Type: text/plain, Size: 2159 bytes --]


Simon South <simon@simonsouth.net> writes:

> This patch updates Bitcoin Core, the reference implementation of the Bitcoin
> protocol, to 0.20.1.
>
> I've followed the instructions[0] for verifying the downloaded source bundle,
> though of course you may still want to do the same.

So, I downloaded sha256 file with the GPG signature, and checked against
this, which was fine.

> My changes remove an obsolete patch whose contents are now part of the
> distribution. They also
>
> - Add autoconf, automake and libtool as native inputs, as this release does
>   not include a pre-generated "configure" script[1].
>
> - Remove protobuf from the inputs, as with the removal of BIP70 support in
>   version 0.20.0[2] this is no longer used[3].
>
> - Add a phase before "build" that sets an environment variable,
>   "BITCOIN_GENBUILD_NO_GIT", as recommended in the release notes[4], to
>   indicate the build is not being made from within a git repository. (This
>   isn't really necessary, since the section of code this variable
>   controls---in share/genbuild.sh---will be skipped anyway without git
>   available in the container. But I've added it for certainty and
>   completeness.)
>
> I've built this successfully on x86-64 and AArch64, and am using it now on
> AArch64 without issue.
>
> [0] https://bitcoincore.org/en/download/#verify-your-download
> [1] https://bitcoincore.org/en/releases/0.20.1/#known-bugs
> [2] https://bitcoincore.org/en/releases/0.20.0/#build-system
> [3] https://github.com/bitcoin/bitcoin/pull/19058
> [4] https://bitcoincore.org/en/releases/0.20.1/#known-bugs
>
> --
> Simon South
> simon@simonsouth.net
>
>
> Simon South (1):
>   gnu: bitcoin-core: Update to 0.20.1.
>
>  gnu/local.mk                                  |  1 -
>  gnu/packages/finance.scm                      | 18 ++++++++----
>  .../patches/bitcoin-core-python-compat.patch  | 28 -------------------
>  3 files changed, 13 insertions(+), 34 deletions(-)
>  delete mode 100644 gnu/packages/patches/bitcoin-core-python-compat.patch

Thanks Simon, this all looks great. I've pushed to master as
fa268b28e1ccc392c85846810d836034c96df3c0.

Thanks again,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  parent reply	other threads:[~2020-11-18  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 23:06 [bug#44493] [PATCH 0/1] gnu: bitcoin-core: Update to 0.20.1 Simon South
2020-11-06 23:15 ` [bug#44493] [PATCH 1/1] " Simon South
2020-11-18  8:48 ` Christopher Baines [this message]
2020-12-06  7:18 ` [bug#44493] [PATCH 0/1] " Martin via web
2020-12-06  8:43   ` Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ima3kq3q.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44493-done@debbugs.gnu.org \
    --cc=simon@simonsouth.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).