From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yNiiEUpS/F9JKgAA0tVLHw (envelope-from ) for ; Mon, 11 Jan 2021 13:27:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yI5zDUpS/F/FUwAAB5/wlQ (envelope-from ) for ; Mon, 11 Jan 2021 13:27:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B820D9402A8 for ; Mon, 11 Jan 2021 13:27:37 +0000 (UTC) Received: from localhost ([::1]:37174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyxEO-0004gJ-OP for larch@yhetil.org; Mon, 11 Jan 2021 08:27:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyxDq-0004f7-Ex for guix-patches@gnu.org; Mon, 11 Jan 2021 08:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyxDp-0005ta-SM for guix-patches@gnu.org; Mon, 11 Jan 2021 08:27:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyxDp-0005qy-Pd for guix-patches@gnu.org; Mon, 11 Jan 2021 08:27:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45409] [PATCH v3 3/3] guix: Split (guix substitutes) from (guix scripts substitute). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Jan 2021 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45409 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 45409-submit@debbugs.gnu.org id=B45409.161037159522444 (code B ref 45409); Mon, 11 Jan 2021 13:27:01 +0000 Received: (at 45409) by debbugs.gnu.org; 11 Jan 2021 13:26:35 +0000 Received: from localhost ([127.0.0.1]:56100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyxDP-0005pw-GQ for submit@debbugs.gnu.org; Mon, 11 Jan 2021 08:26:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyxDN-0005pe-VM for 45409@debbugs.gnu.org; Mon, 11 Jan 2021 08:26:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36668) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyxDI-0005sZ-Ku; Mon, 11 Jan 2021 08:26:28 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57936 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kyxDH-0006eK-A8; Mon, 11 Jan 2021 08:26:27 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210104211927.14959-1-mail@cbaines.net> <20210104211927.14959-3-mail@cbaines.net> <87r1mzrqgk.fsf@gnu.org> <87zh1kidoc.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 11 Jan 2021 14:26:26 +0100 In-Reply-To: <87zh1kidoc.fsf@cbaines.net> (Christopher Baines's message of "Thu, 07 Jan 2021 22:29:23 +0000") Message-ID: <87im83eha5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45409@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B820D9402A8 X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: XweVXQmd6UKH Hi, Christopher Baines skribis: >> I=E2=80=99m reluctant starting this new module while it still contains >> single-short-lived-process assumptions (connection caching & co.). >> >> How about proceeding like this: >> >> 1. Move =E2=80=98http-multiple-get=E2=80=99 to (guix http-client). >> >> 2. Postpone the (guix substitute) bit to a separate patch series to >> leave us the time to polish things a bit and removes the >> single-process assumptions, or just move fewer things to (guix >> substitutes). >> >> You could push (guix narinfo) in the meantime since I think that one is >> almost ready. >> >> How does that sound? Am I being too cautious? > > Well, separating out the connection caching might be helpful for > cleaning things up in the Guix Build Coordinator, I had to add a mutex > currently as I'm guessing the caching isn't thread safe. Precisely, that=E2=80=99s the kind of reason why it=E2=80=99s currently bur= ied in (guix scripts substitute) rather than exposed as a reusable library. :-) > I think it's possible to separate it out if some of the error handling > is pushed down in to the http procedures, and if when they get an error > indicating the connection is unusable, they close the port. Ideally the (web =E2=80=A6) modules would do that (that=E2=80=99s what you = mean, right?) but then we=E2=80=99d have to wait for Guile proper to implement these thin= gs. > I've pushed some rough commits for this to this branch: > > https://git.cbaines.net/guix/log/?h=3Dprepare-to-move-guix-scripts-subs= titute-code > > I'm still struggling with the tests, currently make check hangs, I think > on the challenge tests, and I don't currently have a plan to work out > why the test is hanging. Overall the approach LGTM. How about first getting (guix narinfo) in =E2=80=98master=E2=80=99 (the bit= s we agreed on), and then tackling the rest so that it=E2=80=99s less daunting? Also, I=E2=80=99d like to get the zstd patches in. :-) Thanks, Ludo=E2=80=99.