[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

* gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
as a module.
---
 gnu/packages/linux.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7ed71e9d8f..26b3035518 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -641,6 +641,8 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Allow disk encryption by default
+    ("CONFIG_DM_CRYPT" . m)
     ;; Modules required for initrd:
     ("CONFIG_NET_9P" . m)
     ("CONFIG_NET_9P_VIRTIO" . m)
-- 
2.26.2

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[Leo Famulari]

On Tue, Jan 19, 2021 at 10:47:19PM +0000, guix-patches--- via wrote:
> * gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
> as a module.

This option is already enabled in the kernel configs. Can you say why we
should put it in %default-extra-linux-options as well? Is there some use
case that isn't being served currently?

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

Hi,

I know at least linux-libre-arm64-generic doesn't have the option already set,
and a quick glance through mainline kernel defconfigs made it seem like it'd be
better as a general option. I could have been wrong in thinking it'd do best as
a general option, but it needs to be in linux-libre-arm64-generic, at least.

Thanks.

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[Leo Famulari]

On Wed, Jan 20, 2021 at 03:28:28AM +0000, Caliph Nomble wrote:
> Hi,
> 
> I know at least linux-libre-arm64-generic doesn't have the option already set,
> and a quick glance through mainline kernel defconfigs made it seem like it'd be
> better as a general option. I could have been wrong in thinking it'd do best as
> a general option, but it needs to be in linux-libre-arm64-generic, at least.

Okay, let's do it!

Your patch applies with an author of "guix-patches--- via
<guix-patches@gnu.org>".

Shall I change it to "Caliph Nomble <calnomble@protonmail.com>"?

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

Hi,

> Shall I change it to "Caliph Nomble <calnomble@protonmail.com>"?

Yes, that would be very much appreciated. I have no idea why that happens; I
know the same thing occured for a previous patch I submitted. If you know of
any way to prevent that in the future, too, please tell me.

Thanks!

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[Leo Famulari]

On Thu, Jan 21, 2021 at 10:21:16PM +0000, Caliph Nomble wrote:
> Yes, that would be very much appreciated. I have no idea why that happens; I
> know the same thing occured for a previous patch I submitted. If you know of
> any way to prevent that in the future, too, please tell me.

Alright, I've queued up your patch for the next kernel update.

Regarding your name not being included in your patch submissions, what
commands are you using to create and submit your patches?

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Caliph,

guix-patches--- via 写道：
>> Shall I change it to "Caliph Nomble 
>> <calnomble@protonmail.com>"?
>
> Yes, that would be very much appreciated. I have no idea why 
> that happens; I
> know the same thing occured for a previous patch I submitted.

I doubt there's fault with your patch workflow.

Your non-patch listmails lack a name as well.  For example[0]:

> From: guix-patches--- via <guix-patches@gnu.xxx>

Whilst[1]:

> From: Leo Famulari <xxx@famulari.xxx> [2]

Kind regards,

T G-R

[0]: 
https://lists.gnu.org/archive/html/guix-patches/2021-01/msg00842.html
[1]: 
https://lists.gnu.org/archive/html/guix-patches/2021-01/msg00862.html
[2]: I checked; the domain's still available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

guix-patches--- via 写道：
> From: guix-patches--- via <guix-patches@gnu.org>
> [...]
>
> Caliph,

Hmmm.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[guix-patches--- via]

Hi,

Leo Famulari:
> Regarding your name not being included in your patch submissions, what
> commands are you using to create and submit your patches?

I'm just using git format-patch and send-email (with --from manually set to
this email address), though I do use hydroxide as an smtp bridge to ProtonMail.
Headers are all correct in the send-email confirm interface before sending.

Tobias Geerinckx-Rice:
> Hmmm.

Might be an issue with emails being forwarded through the mailing list and thus
replacing their original address, then? With this not happening in other cases
due to CCs.

Thanks!

[bug#45998] [PATCH] gnu: linux-libre: Allow disk encryption by default.

[Leo Famulari]

On Tue, Jan 19, 2021 at 10:47:19PM +0000, guix-patches--- via wrote:
> * gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_DM_CRYPT
> as a module.

Pushed as 82fd2eeed3335116cac6bd198420da7ba36cbc52