From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EZCuEuw/NWCPIwAA0tVLHw (envelope-from ) for ; Tue, 23 Feb 2021 17:48:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QGnzDew/NWCLaQAAB5/wlQ (envelope-from ) for ; Tue, 23 Feb 2021 17:48:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EF6E15BA9 for ; Tue, 23 Feb 2021 18:48:27 +0100 (CET) Received: from localhost ([::1]:37450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEbnO-0006P5-C8 for larch@yhetil.org; Tue, 23 Feb 2021 12:48:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEbn0-0006MU-O7 for guix-patches@gnu.org; Tue, 23 Feb 2021 12:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEbn0-00085d-Bb for guix-patches@gnu.org; Tue, 23 Feb 2021 12:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEbn0-0001kp-9A for guix-patches@gnu.org; Tue, 23 Feb 2021 12:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46680] [PATCH] gnu: Add midicomp. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Feb 2021 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46680 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou Cc: 46680@debbugs.gnu.org Received: via spool by 46680-submit@debbugs.gnu.org id=B46680.16141024356688 (code B ref 46680); Tue, 23 Feb 2021 17:48:02 +0000 Received: (at 46680) by debbugs.gnu.org; 23 Feb 2021 17:47:15 +0000 Received: from localhost ([127.0.0.1]:60438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbmF-0001jn-5M for submit@debbugs.gnu.org; Tue, 23 Feb 2021 12:47:15 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbmD-0001jb-M8 for 46680@debbugs.gnu.org; Tue, 23 Feb 2021 12:47:14 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9F66820009; Tue, 23 Feb 2021 17:47:06 +0000 (UTC) From: Nicolas Goaziou References: <20210221102137.22967-1-alex@zrythm.org> Date: Tue, 23 Feb 2021 18:47:05 +0100 In-Reply-To: <20210221102137.22967-1-alex@zrythm.org> (Alexandros Theodotou's message of "Sun, 21 Feb 2021 10:21:37 +0000") Message-ID: <87im6iy8va.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6EF6E15BA9 X-Spam-Score: -2.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: oTzBwNUkcIXO Hello, Alexandros Theodotou writes: > * gnu/packages/audio.scm (midicomp): New variable. Thank you. Some comments follow. > + (package > + (name "midicomp") > + (version (string-append "0.0.6-" revision "." (string-take commit 7))) According to the README, the last version is 0.0.8. Also, the above should be written more compactly (version (git-version "0.0.8" revision commit)) > + (synopsis "MIDI compiler") I suggest "Convert SMF MIDI files to and from plain text", which may be more explicit. > + (license license:agpl3)))) I think there is an issue here. The repository has no LICENSE file, and source code files have no license header. The only reference to AGPL3.0 is in the README.md. I'm not sure this is sufficient. WDYT? Regards, -- Nicolas Goaziou