unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 46680@debbugs.gnu.org
Subject: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 18:47:05 +0100	[thread overview]
Message-ID: <87im6iy8va.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210221102137.22967-1-alex@zrythm.org> (Alexandros Theodotou's message of "Sun, 21 Feb 2021 10:21:37 +0000")

Hello,

Alexandros Theodotou <alex@zrythm.org> writes:

> * gnu/packages/audio.scm (midicomp): New variable.

Thank you. Some comments follow.

> +    (package
> +      (name "midicomp")
> +      (version (string-append "0.0.6-" revision "." (string-take commit 7)))

According to the README, the last version is 0.0.8. Also, the above
should be written more compactly

  (version (git-version "0.0.8" revision commit))

> +      (synopsis "MIDI compiler")

I suggest "Convert SMF MIDI files to and from plain text", which may be
more explicit.

> +      (license license:agpl3))))

I think there is an issue here. The repository has no LICENSE file, and
source code files have no license header. The only reference to AGPL3.0
is in the README.md. I'm not sure this is sufficient.

WDYT?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-02-23 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 10:21 [bug#46680] [PATCH] gnu: Add midicomp Alexandros Theodotou
2021-02-23 17:47 ` Nicolas Goaziou [this message]
2021-02-23 18:56   ` Alexandros Theodotou
2021-02-23 19:07     ` bug#46680: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im6iy8va.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46680@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).