From: Marius Bakke <marius@gnu.org>
To: david larsson <david.larsson@selfhosted.xyz>
Cc: 47898-done@debbugs.gnu.org
Subject: bug#47898: [PATCH] [core-updates] Add option --xpath0 to xmllint from libxml2
Date: Tue, 18 May 2021 22:25:46 +0200 [thread overview]
Message-ID: <87im3fbxh1.fsf@gnu.org> (raw)
In-Reply-To: <2f7a02b8290c9728644a9d2c2caad0b9@selfhosted.xyz>
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
david larsson <david.larsson@selfhosted.xyz> skriver:
> Hi, new patch attached. There's a lint warning though:
> "libxml2-xpath0@2.9.10: no updater for libxml2-xpath0". I don't know
> what it means, maybe it should be fixed before committing?
That warning is harmless and affects a lot of packages. I've applied
the patch with a couple minor tweaks:
> +From e1df743329bdfd94fbfdea18303c5c6c6fe13403 Mon Sep 17 00:00:00 2001
> +From: methuselah-0 <david.larsson@selfhosted.xyz>
> +Date: Thu, 1 Apr 2021 08:33:56 +0200
> +Subject: [PATCH] Add option --xpath0
> +
> +---
> + doc/xmllint.xml | 16 ++++++++++++++++
> + xmllint.c | 32 +++++++++++++++++++++++---------
> + 2 files changed, 39 insertions(+), 9 deletions(-)
I replaced this git-style patch header with a short description and an
URL to the upstream issue, like we usually do.
> +(define-public libxml2-xpath0
> + (package/inherit libxml2
> + (name "libxml2-xpath0")
> + (source (origin
> + (inherit (package-source libxml2))
> + (patches (append (search-patches
> + "libxml2-xpath0-Add-option-xpath0.patch")
> + (origin-patches (package-source libxml2))))))
> + (description
> + "Libxml2-xpath0 is like libxml2 but with a patch applied that
> +provides an --xpath0 option to xmllint that enables it to output xpath
> +results with a null delimiter")))
...and sprinkled some markup and punctuation into the description.
Pushed as b58efbc6611550ad9234163e198ff71ace5306ea, thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
prev parent reply other threads:[~2021-05-18 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 18:48 [bug#47898] [PATCH] [core-updates] Add option --xpath0 to xmllint from libxml2 david larsson
2021-05-13 12:41 ` Marius Bakke
2021-05-13 13:21 ` david larsson
2021-05-13 13:29 ` Marius Bakke
[not found] ` <80bc8f6c73d5aa423cf906d59bbcd43e@selfhosted.xyz>
2021-05-15 12:53 ` david larsson
2021-05-15 16:12 ` Marius Bakke
2021-05-15 17:12 ` david larsson
2021-05-15 19:21 ` david larsson
2021-05-18 20:25 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im3fbxh1.fsf@gnu.org \
--to=marius@gnu.org \
--cc=47898-done@debbugs.gnu.org \
--cc=david.larsson@selfhosted.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).