From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AOt8C5Tft2DyjgAAgWs5BA (envelope-from ) for ; Wed, 02 Jun 2021 21:44:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gJ3bBpTft2A4SwAAbx9fmQ (envelope-from ) for ; Wed, 02 Jun 2021 19:44:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1A271A392 for ; Wed, 2 Jun 2021 21:44:19 +0200 (CEST) Received: from localhost ([::1]:47982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loWmo-0002DZ-BD for larch@yhetil.org; Wed, 02 Jun 2021 15:44:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWmY-0002CT-K0 for guix-patches@gnu.org; Wed, 02 Jun 2021 15:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loWmY-0005IF-CK for guix-patches@gnu.org; Wed, 02 Jun 2021 15:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loWmY-000723-8N for guix-patches@gnu.org; Wed, 02 Jun 2021 15:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48797] [PATCH] gnu: Add emacs-vscode-dark-plus. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jun 2021 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48797 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48797@debbugs.gnu.org Cc: rndd@tuta.io X-Debbugs-Original-To: Adam Kandur via Guix-patches via X-Debbugs-Original-Cc: 48797@debbugs.gnu.org, Adam Kandur Received: via spool by submit@debbugs.gnu.org id=B.162266299826951 (code B ref -1); Wed, 02 Jun 2021 19:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2021 19:43:18 +0000 Received: from localhost ([127.0.0.1]:41376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loWlp-00070Y-TT for submit@debbugs.gnu.org; Wed, 02 Jun 2021 15:43:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:35484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loWlo-00070R-VP for submit@debbugs.gnu.org; Wed, 02 Jun 2021 15:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWlo-0002Bh-NQ for guix-patches@gnu.org; Wed, 02 Jun 2021 15:43:16 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loWlm-0004mD-OU for guix-patches@gnu.org; Wed, 02 Jun 2021 15:43:16 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3E469E000A; Wed, 2 Jun 2021 19:43:10 +0000 (UTC) From: Nicolas Goaziou References: Date: Wed, 02 Jun 2021 21:43:09 +0200 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Wed, 2 Jun 2021 21:00:48 +0200 (CEST)") Message-ID: <87im2wgiia.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622663059; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=fBRzYFeylGta2F7nfkVZxs5wsH0KcEtt5AbaiR6RE0o=; b=lZFo20BCHjdigUpBpjROdeJXm2VVqk59x6LuVz2QH1K+eYLRbpM8JoA5iNIPywlfDrCjL5 oEQVfqrF9DvILDPilAekmukqtDhZ7yzDcrJGb6lRxz6W4WEXi4B5igQdL6ANsy5QW6BGqR oRhaqFwQC56L0hfOj9XR9FX5uw8PUcsbNixGglR9PoOZX0HA9hrUiTWKnLKuWoS0c5Rdbh h+3aPeItPl/GwRvDvsRuklpYdEq7IW/FHAVINZn6Gc+U4YY9p3B5hv+v4FEp3J+Lgt7Hxy j+PSI0tS/k5/5/44X4djkvaLeKxR8G05fDjj6PudNcbM5QE008BOo7VfENVeDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622663059; a=rsa-sha256; cv=none; b=HCpAPUJeY1dbuMnfJmamju1ahRLtWvr0rovCngZSlcWA9oqY9qT/Fkx34kS/OSy3yDPNIF BCyRH7Ki/F0c6cimMq9s8+ixna+LRVQD4wc4T4ahwwdn6uOp0EtCt5BJm0FwlLwqaCQ/ll W8JEkWbef4z8wD0qqk+gySym37ZKhU3mm8/cP9Y9jLtP0AIfVyn7yXmMWdED6ssb1DtLdb I6gxf3QBnm5KvYUph+CHCPGV+qJzQSZcZj9s6C9mB47qK0NEnZWo7WTWLdlQ/U8QGw+Q+U BlKH0BBQO3Laz/dqAHPYgJx4Z1MqGS0fQU3Siv1dNj2oxgcymDY3GlB04KgILw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B1A271A392 X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: oolpQs8fD3q6 Hello, Adam Kandur via Guix-patches via writes: > Subject: [PATCH] gnu: Add emacs-vscode-dark-plus. Thank you. Some comments follow. > +=C2=A0=C2=A0=C2=A0 (version "v2.0.0") The version should be "2.0.0". The "v" prefix should be appendend ... > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (url "https://github.com/ianyepan/vscode-dark-plus-emacs-theme") > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (commit version))) ... here with (string-append "v" version) > +=C2=A0=C2=A0=C2=A0 (synopsis "A port of the default VS Code Dark+ theme") The synopsis cannot start with the article "A". You may want to run guix lint to catch this. I suggest the following: Emacs port of the default VS Code Dark+ theme > +=C2=A0=C2=A0=C2=A0 (description > +=C2=A0=C2=A0=C2=A0=C2=A0 "An accurate port of the default Visual Studio = Code Dark+ theme for Emacs.=C2=A0 This theme aims to be as > +identical as possible to the default Dark+ color scheme used by Visual S= tudio Code.") The description cannot start with the article "An" either. See above. Besides, the two sentences have the same meaning. I suggest to drop the first one. > +=C2=A0=C2=A0=C2=A0 (license license:gpl3))) The license is actually gpl3+ if you look at the header of "vscode-dark-plus-theme.el". Also, there seems to be an issue with white spaces. Could you send an updated patch? Regards, --=20 Nicolas Goaziou