From: Mathieu Othacehe <othacehe@gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: 48810@debbugs.gnu.org
Subject: [bug#48810] [PATCH] gnu: Add matterbridge.
Date: Fri, 04 Jun 2021 14:07:50 +0200 [thread overview]
Message-ID: <87im2testl.fsf@gnu.org> (raw)
In-Reply-To: <20210603132231.10168-1-GNUtoo@cyberdimension.org> (Denis Carikli's message of "Thu, 3 Jun 2021 15:22:31 +0200")
Hello,
The linter reports two problems:
--8<---------------cut here---------------start------------->8---
gnu/packages/messaging.scm:2977:5: matterbridge@1.22.2: the source file name should contain the package name
gnu/packages/messaging.scm:2977:5: matterbridge@1.22.2: the source URI should not be an autogenerated tarball
--8<---------------cut here---------------end--------------->8---
which means that you should use:
> + (method url-fetch)
git-fetch here,
> + (sha256
> + (base32
> + "1p3mkfzv4xwm7vz8ja7qsa99qwxb9s61hnjjv65dkkjivlsif5hk"))))
and introduce something like:
--8<---------------cut here---------------start------------->8---
(file-name (git-file-name name version))
--8<---------------cut here---------------end--------------->8---
here. Could you please send an updated patch?
Thanks,
Mathieu
next prev parent reply other threads:[~2021-06-04 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 13:22 [bug#48810] [PATCH] gnu: Add matterbridge Denis 'GNUtoo' Carikli
2021-06-04 12:07 ` Mathieu Othacehe [this message]
2021-06-04 16:11 ` [bug#48810] [PATCH v2] " Denis 'GNUtoo' Carikli
2021-06-06 16:34 ` bug#48810: " Mathieu Othacehe
2021-06-04 16:16 ` [bug#48810] [PATCH] " Denis 'GNUtoo' Carikli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im2testl.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=48810@debbugs.gnu.org \
--cc=GNUtoo@cyberdimension.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).