From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UG+tJNSU52BFTgAAgWs5BA (envelope-from ) for ; Fri, 09 Jul 2021 02:14:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sBZpINSU52BiHgAAB5/wlQ (envelope-from ) for ; Fri, 09 Jul 2021 00:14:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4910F1855B for ; Fri, 9 Jul 2021 02:14:12 +0200 (CEST) Received: from localhost ([::1]:38766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1e9j-0001dV-9p for larch@yhetil.org; Thu, 08 Jul 2021 20:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1e9b-0001dN-SK for guix-patches@gnu.org; Thu, 08 Jul 2021 20:14:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1e9a-0004KW-60 for guix-patches@gnu.org; Thu, 08 Jul 2021 20:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1e9Z-0003XA-S8 for guix-patches@gnu.org; Thu, 08 Jul 2021 20:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Jul 2021 00:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: zimoun , 49457@debbugs.gnu.org, Andrew Tropin Received: via spool by 49457-submit@debbugs.gnu.org id=B49457.162578959013514 (code B ref 49457); Fri, 09 Jul 2021 00:14:01 +0000 Received: (at 49457) by debbugs.gnu.org; 9 Jul 2021 00:13:10 +0000 Received: from localhost ([127.0.0.1]:57881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1e8k-0003Vu-0S for submit@debbugs.gnu.org; Thu, 08 Jul 2021 20:13:10 -0400 Received: from out1.migadu.com ([91.121.223.63]:26526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1e8e-0003Vd-OK for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 20:13:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1625789582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=huAIOLAakmcX6eNa3yMqBSKErLwYduP8jFgh5GvQF+w=; b=cowbYImXxY5wnF01Xbi+B+qin/kP1krlN/rx3L9hRXDxXubQtNhgJnOX/82M1qf+/iU1Cm v+P2ApUOicPZhz2rfa5O7q1gcPzDNCBlsjN3fmt844lRK0ryrFmINTNCntX/nHkbAt3CX6 ZVvRl5niYIXipDmQgdkiWI8HiGaCFHSyN+JK1VObzX0bNApUO7KvJNOWV2IZVC3tszdJRb x6Y4z2tjUE0Vlz3Po2wIqZIm+rWzKab44yMWibFu2YvgnvaJ9LehHl8h6cksMQOSXoSV54 jZQDqU9D7n6ODfBmthlX/sQ1sZmmG7pN6RfJ5Ja+cAYLAX0vvEMS7Pwtc/jxNQ== From: Kyle Meyer In-Reply-To: <87k0m1nihl.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> <87h7h5p2gt.fsf@nicolasgoaziou.fr> <87mtqx82or.fsf@kyleam.com> <87k0m1nihl.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 20:13:00 -0400 Message-ID: <87im1k8hv7.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625789652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=huAIOLAakmcX6eNa3yMqBSKErLwYduP8jFgh5GvQF+w=; b=pzgCsnXYs3qBI08T0OsUHhwJk4hjFNCpY2CD0dsesj8STdSeT6sxLR0x1hm7KQjQjXSjyW lryJrnqCOD2Y+upiphc9KxS7yKK6p+BGKDNWJeaKCEeivdsjVGK2DF91+6dJ6oth6P4eD0 cpFlR4uPZyVk9TS+VOJqp92cXXdqwIOMDfcz6EP6l2QePMDjuncxupK8a4DoKynhFzT/vw YpFJZ8NoC0hzF59jv26tFhiBYnAh5sMTqRc+cW9vizthjZi3fevEt9pdiUmtxXDJ+4GXuM 5syhIDHB0/X02/lQ6T9oURWZog5TQ6veLahVDvwjrAN2fuIEPwOWweKBWl+OyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625789652; a=rsa-sha256; cv=none; b=B/bs017pWhNrbhLX9z1DbAMUMK7Auw4ZQD9EeClgL24wvkPSlGxkLhKGU5O4jfWglssBde EPW1rabmm5xLUT92WYbyqkzz5mDd4UYxBKd5LADMVWljokX1AgxsQJ4x2xVLaQaQIauFvQ ZLMhx3AtikP5sBTNiUhKjarimYJU6zYQnHtoCbwpKO72dopYdmLUBk6QRyBTrs45WVPjjr bmXvUI0GnP47esIfg33CsWrctsbRcO9jwj1HNEdoNTAcNfJDRHiTCF9A50itmfDVYZSGM9 pcgJDIqAoleXNakaOcK4aBSRR+WPQSLbSg8c/G8fRGexe3sC9BS/BEAMDMjVIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=cowbYImX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.09 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=cowbYImX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4910F1855B X-Spam-Score: 0.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3TI1NCgvNROB Nicolas Goaziou writes: > Kyle Meyer writes: > >> Nicolas Goaziou writes: >> >>> However, I think it is a bug if Emacs Magit does not work with git in >>> profile. We should modify the source so both magit-git-executable and >>> magit-gitk-executable point to those from inputs. >>> >>> I suggest to open a new bug report about it, WDYT? >> >> Rewriting magit-git-executable to an absolute file name will break Magit >> for those that use it over TRAMP. > > Point taken. However, such users can fix it by modifying the > `magit-git-executable' defcustom again, can't they? Sure. Given the number of "oops, some change didn't consider tramp compatibility" bugs that crop up in Magit, my guess is that Magit is widely used over TRAMP. So, potentially many users are affected, but I agree it's an easy fix once they spend time to debug what the issue is. (That collectively could amount to a lot of wasted time, so in my eyes it depends on what the practical problem being fixed is.) > So, the situation would arguably not be worse that what it is currently, > since it simply doesn't work for users relying on a local installation > of git, and those are probably more common. Hmm, I'm not clear on what the current problem is; a user will typically have "git" on their path one way or the other. Given Magit's heavily used, I would have expected to see many Guix bug reports about about it if it were a problem in practice. But 1) perhaps I'm missing something or 2) perhaps for philosophical reasons or to promote best practices rewriting magit-git-executable is worth the breakage. My drive-by comment was just to mention the possible breakage [*]. (I don't have a personal stake in what's done because I don't install Magit from Guix.) > Also, a third option: since we're not making use of git input at > runtime, why should it be an input at all? If it is needed at build > time, a native-input should suffice. Yeah, that sounds right (though I haven't tested it). [*] And it might not break things for much longer. On Magit's end, Jonas recently floated the idea of not using magit-git-executable when using TRAMP. https://github.com/magit/magit/issues/4433#issuecomment-875964528