From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YEcvFdI4+GD/3wAAgWs5BA (envelope-from ) for ; Wed, 21 Jul 2021 17:10:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2KcKEdI4+GDmHgAA1q6Kng (envelope-from ) for ; Wed, 21 Jul 2021 15:10:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F354144B7 for ; Wed, 21 Jul 2021 17:10:09 +0200 (CEST) Received: from localhost ([::1]:54852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6DrN-0001og-0b for larch@yhetil.org; Wed, 21 Jul 2021 11:10:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DrG-0001oH-4l for guix-patches@gnu.org; Wed, 21 Jul 2021 11:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6DrF-0000yn-TM for guix-patches@gnu.org; Wed, 21 Jul 2021 11:10:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6DrF-00086e-MD for guix-patches@gnu.org; Wed, 21 Jul 2021 11:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49419] [PATCH 0/4] Essential home services Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Jul 2021 15:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49419 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 49419@debbugs.gnu.org Received: via spool by 49419-submit@debbugs.gnu.org id=B49419.162688016431104 (code B ref 49419); Wed, 21 Jul 2021 15:10:01 +0000 Received: (at 49419) by debbugs.gnu.org; 21 Jul 2021 15:09:24 +0000 Received: from localhost ([127.0.0.1]:38289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Dqe-00085c-6r for submit@debbugs.gnu.org; Wed, 21 Jul 2021 11:09:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Dqc-00085N-Gk for 49419@debbugs.gnu.org; Wed, 21 Jul 2021 11:09:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51006) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6DqV-0000V9-Ln; Wed, 21 Jul 2021 11:09:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45274 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DqG-0007O4-LQ; Wed, 21 Jul 2021 11:09:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y2akhiz1.fsf@trop.in> <87v956g1g5.fsf@trop.in> Date: Wed, 21 Jul 2021 17:08:55 +0200 In-Reply-To: <87v956g1g5.fsf@trop.in> (Andrew Tropin's message of "Mon, 19 Jul 2021 11:04:01 +0300") Message-ID: <87im13g0vs.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626880210; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=A3FQRkeKPSDykQrb9ML77KVxhVIBCEr17VlR1xvwzrs=; b=RSvXFwvaX6OofYx3POXxKn+b7avkNjBnH8G1MuW8s92EUkITQL+EkRaB4PfTb0/6001n4A NAtAOgTnh2NmiF3nSEeBDZiIsgdjUoc6XCtLt6Y2gUgaSfPqOO78APAeMNfDzo4ssomg1m tW8hR2QlPsC5S4FrBW6eIzcliq04hwrNSm1qWA7uiNHe9eKK8AFrzAD++i179wErl6J+Ud bdmDmoZ5ahlKa+Uo0+sZGvM2lZjRUaRgmOmji7h+tWFlD7xnbV6pJ9EY1q1NRbkQh2wcc5 ZqXa8S7uWsPfLZNV8rl0RfilAB4FHS7z4VcyQrsvIeZFvilLyT+Swx3/6fG9iA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626880210; a=rsa-sha256; cv=none; b=rC8/kUjCZBbDtJRwh4kRfHGkYZDIkBMRCGthLr6Vdyk8tebNFp3UPYHmKW58zOCsDGnjzO Dv2o0SDy6zTPk4ezl/0Qq98I7dn/65oH5t0QkbWPc5PBeOtNcOVYN7mHh7Bi9evRXiVeUA +C1ZZhmZ7l30hOXoSm9Ye3x5A70GgPaZAUH3bD1HqodjrjImxMsMRTjdFIFYc7CQ7tjRFO blRtPgVXwPPM1ocPp/oKgc0AhAWwwkrUWmKTjZ6CPTf5c21TcwI5D5ot0y7cRH4soMu6EM v1Fy9m11y3JZq8A4dwoJmZimCRkLrq9IJjzfGUI01KKR3VpmFivbzN8Nbryj1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F354144B7 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: Gah9xQs1UvlF Hi Andrew, Andrew Tropin skribis: > Diff with v2: Prevents unecessary calls to system* > > Please, when review finished, apply against guix-home-wip branch. > > Andrew Tropin (4): > home-services: Add most essential home services > home-services: Add home-run-on-change-service-type > home-services: Add home-provenance-service-type > home-services: Add fold-home-service-types function Thanks for sending this first patch series! How would you like to proceed? Sending patches that add essential services, and then (guix scripts home =E2=80=A6) modules? I agree we should apply it all in =E2=80=98wip-guix-home=E2=80=99 for now. Some general comments: =E2=80=A2 Please remove tabs from Scheme files. =E2=80=A2 Please do not write documentation in commit logs. For example, patch #1 explains the different service types, but to me, that=E2=80=99d belong in a comment or (better yet) in a section of the manual. For commit logs, we use ChangeLog style: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html It=E2=80=99s OK if you don=E2=80=99t get the fine points right from the= start, committers can tweak it for you. :-) =E2=80=A2 When there are tests or documentation, add them in the commit t= hat adds the corresponding functionality. =E2=80=A2 Regarding module names: what about putting everything in the (g= nu home =E2=80=A6) name space. For services, I wonder if we could simply = use (gnu services home), for the essential services, and other (gnu services =E2=80=A6) module, but that assumes some code can be shared be= tween System and Home. Thoughts? I=E2=80=99ll look at the actual patches later, but I invite others to chime= in too. :-) Thanks! Ludo=E2=80=99.