From: Xinglu Chen <public@yoctocell.xyz>
To: phodina <phodina@protonmail.com>,
"50661@debbugs.gnu.org" <50661@debbugs.gnu.org>
Subject: [bug#50661] [PATCH v2] gnu: Add valeronoi.
Date: Wed, 22 Sep 2021 18:27:31 +0200 [thread overview]
Message-ID: <87ilyslgng.fsf@yoctocell.xyz> (raw)
In-Reply-To: <NxytQPoXMo3dJwVnfE3VBcmyZDccUmTF19s4_y6nLNQIq_NB4lCIi43s1dlC_dO_oOotYMGdAUgBq5kIsESEnyLD7INugwg7wg0heE9iv38=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 2956 bytes --]
On Sat, Sep 18 2021, phodina via Guix-patches via wrote:
> Fixed forgotten formatting issues.
>
> --8<---------------cut here---------------start------------->8--
>
> * gnu/packages/engineering.scm (valeronoi): New variable.
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 46622f3a1f..f61fa04a43 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -24,6 +24,7 @@
> ;;; Copyright © 2021 qblade <qblade@protonmail.com>
> ;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
> ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
> +;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -127,6 +128,7 @@
> #:use-module (gnu packages xml)
> #:use-module (gnu packages xiph)
> #:use-module (gnu packages openkinect)
> + #:use-module (gnu packages xdisorg)
> #:use-module (gnu packages xorg))
>
> (define-public librecad
> @@ -1168,6 +1170,42 @@ educational use. As such, there is an emphasis on capabilities that improve
> the 'showing the effect of'-style of operation.")
> (license license:gpl2+)))
>
> +(define-public valeronoi
> +(package
> + (name "valeronoi")
> + (version "v0.1.3")
The version string should not contain the “v”, and the latest version
seems to be 0.1.4.
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/ccoors/Valeronoi")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key outputs #:allow-other-keys)
> + (invoke "./valeronoi-tests"))))))
The ‘outputs’ argument isn’t used, and the ‘check’ phase doesn’t respect
the ‘--without-tests’ package transformation. The following snippet
would fix this.
(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "./valeronoi-tests")))
> + (inputs `(("qtbase" ,qtbase-5)
> + ("qtsvg" ,qtsvg)
> + ("openssl" ,openssl)
> + ("libxkbcommon" ,libxkbcommon)
> + ("cgal" ,cgal)
> + ("gmp" ,gmp)
> + ("mpfr" ,mpfr)
> + ("boost" ,boost)))
> + (synopsis "WiFi mapping companion app for Valetudo")
> + (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
> +for generating WiFi signal strength maps. It visualizes them using a Voronoi
> +diagram.")
> + (home-page "https://github.com/ccoors/Valeronoi")
> + (license license:gpl3)))
The ‘COPYING’ file says gpl3+.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-22 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 13:25 [bug#50661] [PATCH] gnu: Add valeronoi phodina via Guix-patches via
2021-09-18 13:37 ` [bug#50661] [PATCH v2] " phodina via Guix-patches via
2021-09-22 16:27 ` Xinglu Chen [this message]
2021-09-27 22:52 ` [bug#50661] [PATCH v3] " phodina via Guix-patches via
2021-12-03 15:36 ` phodina via Guix-patches via
2021-12-03 20:39 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilyslgng.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50661@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).