From: pinoaffe <pinoaffe@airmail.cc>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 50755@debbugs.gnu.org
Subject: [bug#50755] [PATCH v2] import: Generate list of importers based on available modules
Date: Mon, 27 Sep 2021 20:27:30 +0200 [thread overview]
Message-ID: <87ilylswkt.fsf@airmail.cc> (raw)
In-Reply-To: <CAJ3okZ3FtEN8ytJqjv0HiCkpgMxp2KbofUB07i3aV-3c7c3SOA@mail.gmail.com>
Hi,
thank you for your feedback!
zimoun writes:
> First, I think, it breaks "guix import --help". Therefore, this patch
> needs a v3. :-)
I sent a v3, thanks :)
> The question is: which performance loss is acceptable here?
To me a performance loss similar to the one you describe would be
acceptable, particularly since it should be a constant performance hit
for every time ~guix import~ is called, aka it won't significantly
impact long-running import commands. However, I think I may be somewhat
biased on this one, so it'd be great if others could weigh in :)
Kind regards,
pinoaffe
next prev parent reply other threads:[~2021-09-27 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:24 [bug#50755] [PATCH] import: Generate list of importers based on available modules pinoaffe
2021-09-23 18:07 ` Sarah Morgensen
2021-09-23 21:17 ` pinoaffe
2021-09-23 21:19 ` [bug#50755] [PATCH v2] " pinoaffe
2021-09-27 14:28 ` zimoun
2021-09-27 18:27 ` pinoaffe [this message]
2021-09-27 18:20 ` [bug#50755] [PATCH v3] " pinoaffe
2021-09-27 20:09 ` zimoun
2021-09-28 9:51 ` Maxime Devos
2021-09-28 14:39 ` pinoaffe
2021-09-29 20:59 ` Maxime Devos
2021-09-30 8:17 ` pinoaffe
2021-09-30 8:37 ` Maxime Devos
2021-10-11 11:51 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilylswkt.fsf@airmail.cc \
--to=pinoaffe@airmail.cc \
--cc=50755@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).