From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CAzmKCZWmWHIRwEAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 21:10:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yPGUJCZWmWH4NAAAB5/wlQ (envelope-from ) for ; Sat, 20 Nov 2021 20:10:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1944823412 for ; Sat, 20 Nov 2021 21:10:14 +0100 (CET) Received: from localhost ([::1]:54110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moWgf-0007Op-B6 for larch@yhetil.org; Sat, 20 Nov 2021 15:10:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moWgU-0007OK-Ha for guix-patches@gnu.org; Sat, 20 Nov 2021 15:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moWgU-0001aL-59 for guix-patches@gnu.org; Sat, 20 Nov 2021 15:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moWgU-0005N3-05 for guix-patches@gnu.org; Sat, 20 Nov 2021 15:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. In-Reply-To: <20211114124151.36743-1-philip@philipmcgrath.com> Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163743895020561 (code B ref 51838); Sat, 20 Nov 2021 20:10:01 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 20:09:10 +0000 Received: from localhost ([127.0.0.1]:43723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWfP-0005Kd-R1 for submit@debbugs.gnu.org; Sat, 20 Nov 2021 15:09:10 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moWfO-0005KF-96 for 51838@debbugs.gnu.org; Sat, 20 Nov 2021 15:08:54 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3FD795C00D5; Sat, 20 Nov 2021 15:08:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 20 Nov 2021 15:08:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=drjm6TKiBGlj07b5FfV83MEeAs3KmWlQq3uGaDqsKuI=; b=fWa/heri eXQQ4xe4rkiDkR5rIDf2QF/AMO5vCKN8U6ocQFOFIR1hBjYH79HhRlF2cq1Tbj+Y 8epkXAFJrZ/Vsb5qRhbrdNn8r7xWsG3swdpnJ3XEIxIaM9bsksxtuJkFnwsWoLRm lodnX0ME6Wlveh8ut/joTpSQpkWABLTdv9CYezyGJvPIKw1KRC2oaDUGBJBEtTST pUbZBTwNgeQSGBUFHmWSKlRZ+VLyxwgBYOPh7cyy1vKogPRPBcPN4CT4k0pUAhUp zDQpuZsoW/kWbEGmTZgfSBClYdSqL840CdPZFd+zcNea+LGQEoR0dQolo+fcp5Yf S2yfDmVdHsTAKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgedtgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvuffffhfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpeefieeufffhuedujedttdekvdetffevudeigeefvdekkefhkeetgfehtdeu gfffkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 20 Nov 2021 15:08:48 -0500 (EST) From: Timothy Sample Date: Sat, 20 Nov 2021 14:55:31 -0500 References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-18-philip@philipmcgrath.com> <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@gmail.com> Message-ID: <87ilwmbne7.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637439014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=drjm6TKiBGlj07b5FfV83MEeAs3KmWlQq3uGaDqsKuI=; b=L7ptu7xS4y/qFL72OdvsW9DhUpiP9MZf4+7b37Jpkmw7yV/F+wz9V/T3ibGaZCfz9h/uLJ iOGYmDzn6m8WJac0G65UK5tnJWWNUqk8hJAjOCovliauBurqtXZxara74CxgMkZTXifI9C NOmRWV743f0tPIiAxSe64zwI8DYp2tws7m3MBqraqj7CApjQvhiYlK8DuCmaqbCZImyBOW 0Oc88pTHc0yWYeluozvaDHGstiH31qfFbcFF2vG2aqVvdX56iwRE+zozEGvJP8EFZ0fZUw ZyBVe5jqLwdL9uiMB1ViEnk9sQ7+Awd3W6dXlek0T1RJieFiJJiLaBIpBlDvCw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637439014; a=rsa-sha256; cv=none; b=h3OxOFu93S74OxxIQ+swIWrS9kGCQW4ftjU1Km+PaC0AU40j6EsWX5o8PkK+iE3SbIXVgn 5YWEvy+cD8D/g7M+7GEutjTBusMON9s4HfzZSoq6lLc+jetegGHUTY0YoDhBV6ary4OdwX haeNfK902gd74j1dLA4md+RNdFcCrN4kam8m/SPrpGeekLwSysAjmSCUFi6lTQxppg2uFI u5vo+O9/DZTGxbM+aFzqs7V6QPwW6Qvim2Uc8x7HPAVb9EKqTst047P2wOmHXGeoYqbswJ ag1Jz15RbqsrUa5N14qKoUo23UTBFNF1EPtiFdTU65KQSdkkZhjWVqaRwAwlmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="fWa/heri"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="fWa/heri"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1944823412 X-Spam-Score: -1.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: /5a1Mtk4MJ3w Hello, Philip McGrath writes: > On 11/20/21 02:46, Liliana Marie Prikler wrote: >> Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath: >>> * guix/build-system/node.scm (lower): Add an optional #:libuv? >>> argument to tell the build system to add the version of libuv >>> used as an input to the #:node package as an additional implicit >>> input, so that packages needing libuv always get the correct version. >> Would it change something if we always had libuv as implicit input? I >> don't think it'd do much for closure size, but it might impact implicit >> package search as proposed by my solution to the #:absent-dependencies >> thing. > > From a Guix perspective, I don't think it would make much difference, > since libuv is always needed by node itself. Maybe it would require > more grafting than would be needed otherwise? > > But I think the recommendation for authors of node add-ons is to avoid > libuv unless it's really needed, because it has fewer stability=20 > guarantees that other Node.js APIs. My assumption is that most packages would ignore the libuv headers, and they wouldn=E2=80=99t retain a reference to it (except via Node.js itself). Hence, I don=E2=80=99t think it would make any difference either to graftin= g or closure size to just always add it. -- Tim