From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eLDvLU7i4GFDCQEAgWs5BA (envelope-from ) for ; Fri, 14 Jan 2022 03:39:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ECJ/Jk7i4GEPjwAAG6o9tA (envelope-from ) for ; Fri, 14 Jan 2022 03:39:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5088427170 for ; Fri, 14 Jan 2022 03:39:10 +0100 (CET) Received: from localhost ([::1]:35742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8CUf-0007HJ-H4 for larch@yhetil.org; Thu, 13 Jan 2022 21:39:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8CUY-0007HB-4P for guix-patches@gnu.org; Thu, 13 Jan 2022 21:39:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8CUX-0006IS-Qg for guix-patches@gnu.org; Thu, 13 Jan 2022 21:39:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8CUX-0000D8-PC for guix-patches@gnu.org; Thu, 13 Jan 2022 21:39:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53213] [PATCH] daemon: Always default to gzip for log compression. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Jan 2022 02:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53213 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 53213@debbugs.gnu.org Received: via spool by 53213-submit@debbugs.gnu.org id=B53213.1642127885718 (code B ref 53213); Fri, 14 Jan 2022 02:39:01 +0000 Received: (at 53213) by debbugs.gnu.org; 14 Jan 2022 02:38:05 +0000 Received: from localhost ([127.0.0.1]:34972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8CTc-0000BW-NP for submit@debbugs.gnu.org; Thu, 13 Jan 2022 21:38:04 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:33758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8CTa-0000B1-7f for 53213@debbugs.gnu.org; Thu, 13 Jan 2022 21:38:02 -0500 Received: by mail-qt1-f181.google.com with SMTP id h15so5057610qtx.0 for <53213@debbugs.gnu.org>; Thu, 13 Jan 2022 18:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mSiBZwdBhGa8Mtp1x+GClslXCSvD3XB/naUr/+QFQkI=; b=X4EK0ryav1B15IPgyUkekSMzq7DIGPGF2lpzoqyNYroQ+P+amQChtHb3nDyIypoqUi D09Xs8Uv8QRvuqTnkm3hgratyShRtuz+5za15GqiEN4AnJFmaUWc80+MZE+vbAsH57AX 3sx7LNkbsX+5h68mXbmrpFnss7nPjuo3KOS6P2A6tWVelEBXXMuQEiEYlPZqX5fwW6UE inYl2bYgbYObs6hcuqpZPeX2Ho/4IE/w0uBK3dnb5KFvY4ss/XXYGeNzaALOQiPf1DOK kvaV9FaqSfEeXJHUm+wYRqpRYAlSCPhKQTNiQBeY3sHc+Ov4gwXlvWZe5DtfNNXNdDuB bljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mSiBZwdBhGa8Mtp1x+GClslXCSvD3XB/naUr/+QFQkI=; b=wXsnKClGCVXQO/JeNBjfkYkCYF+IWbC0h0DR79BE0tfR6Jyq9GUZ7hUYp9V/VUusyJ 3/MAnub4SlHGtopsEwFC9vZhb96/xm7WF4Owy8vNwEu7yfSAMILm0Sc7v9Z4nZJ++oFX iP0W/01TSBcU7kJHxS36W9+i2ttKbnxqAjzdHWdM0COezluC+fKtCp+vCvOUHsQnVLBj 5/1Cj9d19FHh5DBlhSH35GPKP5N1DcS8qf+H8OciSswDkvv/U7pnhnl44smDMPN52TVk 47MtGYoYCk+YO4RrQ0449cs6XvO6nUfYmRQAiEET6wr5mgQ7239hB+06bvNI1cJH1vSQ JoRg== X-Gm-Message-State: AOAM530Ik95pAHqq5GSRc4gZe1wvdcO/Pkb3XxbbirsoYoo98ay1KIGw MOn6Ef0eeAQb1zsjeCgUWXpUKXTO3Lgqkw== X-Google-Smtp-Source: ABdhPJzK+AUbA0lYtbuiPLbPRM7FaPVYyBNzgJd+nSEpFSXOYlwd2a0mPB1Lexjl5tUgVx7zmUWqQA== X-Received: by 2002:ac8:5bd1:: with SMTP id b17mr6070909qtb.171.1642127876565; Thu, 13 Jan 2022 18:37:56 -0800 (PST) Received: from hurd (dsl-152-155.b2b2c.ca. [66.158.152.155]) by smtp.gmail.com with ESMTPSA id s9sm2956177qki.99.2022.01.13.18.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 18:37:56 -0800 (PST) From: Maxim Cournoyer References: <20220112172118.12250-1-ludo@gnu.org> Date: Thu, 13 Jan 2022 21:37:55 -0500 In-Reply-To: <20220112172118.12250-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 12 Jan 2022 18:21:18 +0100") Message-ID: <87ilunxcsc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642127950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mSiBZwdBhGa8Mtp1x+GClslXCSvD3XB/naUr/+QFQkI=; b=eR7vjfFYPh2wFeb5JSypL0VtmwH/UD+T8b4q/VpCzW2tcbb4I36KZTtzpQBxhgnWqA7UXL 7XvbnRInzL7BxOGyyTL7LIEIMkvlBjpRGKaGt2hEeueWQlMF79zoHocNIT+NZ6r7yTFox0 uRMonDDClToOJ5G8WBNra/1aNGc3YXyVA10RUfevA1z0/Ayc84OO8JGX/fSCrYw63qNuNH y75DDfw1vhW5sKXwcXCpuLWsnINOvLor578J4g5KzfL9zvoLLg1S6wnLiDB70uJ4LLp1lZ uqY3MyZK1erLxWd3MjPV9dK0yngPyeEdLvE6mU9wlC115M1ej1tf7CCwH5ascw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642127950; a=rsa-sha256; cv=none; b=TTc+RkrWqO604kLDQix1V1epIbDecyGUNOYRmQ+cNco2652LjzeFRuKsFtLWhIuUoLuVRz 0EEW39zwVEgYFTKRVtRsR+zf66plJpkQMgkXL8ykNuUPgww608pvmbjcVt6hv4sN0D7Rbi SC4hNqtU6JheGTfdMomkGFv982A2o8RKtGLoaU/ZC3mhcwqF8KgXEJ2rlP5gCZ3Ct2mALA IP0FCRMRIqphXp3fufe7/oXRYY7wrGr6ElTmsfI8SrbSmbnEAKxkR5Q+b0rUleB5ULWWzr it+oasmS6BCmustxZZVyzgwTXHVmE1ggaPlSkh/0iJE4rZC+fIF1Kg2DjG20Lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=X4EK0rya; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=X4EK0rya; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5088427170 X-Spam-Score: -2.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: hWtKGShNoWYd Hi Ludo, Ludovic Court=C3=A8s writes: > * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression' > default to COMPRESSION_GZIP unconditionally. > * gnu/services/base.scm ()[log-compression]: Default > to 'gzip. > * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly. > --- > doc/guix.texi | 4 ++-- > gnu/services/base.scm | 2 +- > nix/libstore/globals.cc | 4 ---- > 3 files changed, 3 insertions(+), 7 deletions(-) > > Hello! > > I think bzip2 compression of the build logs doesn=E2=80=99t buy us much, = it > doesn=E2=80=99t play well with =E2=80=98guix publish=E2=80=99, and bzip2 = is generally rather > uncommon these days=E2=80=94hence this patch. > > Thoughts? > > Ludo=E2=80=99. I haven't tried it, but the idea and code LGTM. Thanks! Maxim