From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 53213@debbugs.gnu.org
Subject: [bug#53213] [PATCH] daemon: Always default to gzip for log compression.
Date: Thu, 13 Jan 2022 21:37:55 -0500 [thread overview]
Message-ID: <87ilunxcsc.fsf@gmail.com> (raw)
In-Reply-To: <20220112172118.12250-1-ludo@gnu.org> ("Ludovic Courtès"'s message of "Wed, 12 Jan 2022 18:21:18 +0100")
Hi Ludo,
Ludovic Courtès <ludo@gnu.org> writes:
> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression'
> default to COMPRESSION_GZIP unconditionally.
> * gnu/services/base.scm (<guix-configuration>)[log-compression]: Default
> to 'gzip.
> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly.
> ---
> doc/guix.texi | 4 ++--
> gnu/services/base.scm | 2 +-
> nix/libstore/globals.cc | 4 ----
> 3 files changed, 3 insertions(+), 7 deletions(-)
>
> Hello!
>
> I think bzip2 compression of the build logs doesn’t buy us much, it
> doesn’t play well with ‘guix publish’, and bzip2 is generally rather
> uncommon these days—hence this patch.
>
> Thoughts?
>
> Ludo’.
I haven't tried it, but the idea and code LGTM.
Thanks!
Maxim
next prev parent reply other threads:[~2022-01-14 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 17:21 [bug#53213] [PATCH] daemon: Always default to gzip for log compression Ludovic Courtès
2022-01-14 2:37 ` Maxim Cournoyer [this message]
2022-01-18 17:53 ` bug#53213: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilunxcsc.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=53213@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).