From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +GPfN24wFWLCEAAAgWs5BA (envelope-from ) for ; Tue, 22 Feb 2022 19:50:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4IZaNG4wFWKEyQAAauVa8A (envelope-from ) for ; Tue, 22 Feb 2022 19:50:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FFD932189 for ; Tue, 22 Feb 2022 19:50:22 +0100 (CET) Received: from localhost ([::1]:39320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMaEv-0008P1-I4 for larch@yhetil.org; Tue, 22 Feb 2022 13:50:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMaEb-0008Ot-Vu for guix-patches@gnu.org; Tue, 22 Feb 2022 13:50:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMaEb-0008BV-Mi for guix-patches@gnu.org; Tue, 22 Feb 2022 13:50:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMaEb-0002BV-Lt for guix-patches@gnu.org; Tue, 22 Feb 2022 13:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53319] [PATCH] gnu: Add n2n. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Feb 2022 18:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= , 53319@debbugs.gnu.org Received: via spool by 53319-submit@debbugs.gnu.org id=B53319.16455557888372 (code B ref 53319); Tue, 22 Feb 2022 18:50:01 +0000 Received: (at 53319) by debbugs.gnu.org; 22 Feb 2022 18:49:48 +0000 Received: from localhost ([127.0.0.1]:42665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMaEO-0002Ay-34 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 13:49:48 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:62991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMaEL-0002Ag-Aj for 53319@debbugs.gnu.org; Tue, 22 Feb 2022 13:49:46 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id EAC804000D; Tue, 22 Feb 2022 18:49:37 +0000 (UTC) From: Nicolas Goaziou References: <87r18stbll.fsf@nicolasgoaziou.fr> Date: Tue, 22 Feb 2022 19:49:34 +0100 In-Reply-To: (Maxime Devos's message of "Tue, 22 Feb 2022 12:36:24 +0100") Message-ID: <87ilt63fep.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645555822; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=py/gCXaXVRWmEsmjJhwPW5PWRqLu9RB+90GmD1BjfHA=; b=lonGj1GEVtnowKb8U7CohnQIl0RAy+rfyKjsUp7rPF750YT2ckLZ7imvxDnAA/12iWYE5E VvZ7FeHM+iP6+BCBQaLQLWv+R8lKZkqIMq6V5Q/zcKwS1s/6h0BlT3ByT1nlI8JSqKkuIf 6yHEv4z30LRBpSrO2eiFYtei07GBfnTX7/x8Wh3FYagx8iampjMLTag4BmolIcx84llIQS kn8Iaoafy2cxJfrt2xZ2XAmiTMPrJh5VaBxV/oumOJO+s0OqCh5Ct5/CMNbRTJ0JZ/+Lta 42dYG6F4+2VGCbVrCEObrPxl9dDo0LSo07gwGaUM1CxKTsRE6PeV7o0QSir7UA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645555822; a=rsa-sha256; cv=none; b=SupI6d7rt/feWJ7KUeJ6blJo5mBpAR2DT6CNS9CoIFfXxInvWzvD1s8uX19k6tJZqo6ecg EVjMRM+nCTC4SGfuN+qzhskk+oJ+jGvS+C0YCA1iJr9XVwwPdufz4s9gW8EtMlp2C6sPgw GuzDLi9gAjShaaw8NEIbDGbudEYY4LqXPhucAMqB4JZJHRVX2/ZwOqajNqbQEpQ0IDhmxB 7/RW6YNc0mOuy7lyC6lN/fi74ofIZn3lIsLL4ufzN+rexfliV397WSRnbcr7uChvDM/TsF i7iKl3s1OQ0eoQHzAmiAe/SkSp3ruGSLyjVTMjrM89Ipq24M3HagrFazAAlx7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6FFD932189 X-Spam-Score: -3.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: JdgLbgQmScje Hello, Maxime Devos writes: > 'configure' is run during build, so for cross-compilation, a sh from > 'native-inputs' shoud be used instead of 'inputs': > > (("/bin/sh") (search-input-file (or native-inputs inputs) "/bin/sh")) True, I keep forgetting about this. It would be more natural to use (search-input-file native-inputs "/bin/sh"), but, IIRC, native-inputs may be empty if we are not cross-compiling. I will fix it. > or simpler: > > (("/bin/sh") (which "sh")) IIUC, search-input-file is a replacement for `which', so that seems to be going backwards. Of course, if `which' is the preferred solution for package style, I'd love to hear a confirmation about it. > Also, this package definition packages version 2.8. Why not package > the latest version instead? The OP waited one month without any feedback. I consider this is more respectful to apply the patch in its current version rather than requesting more changes now. YMMV. Of course, the update can happen in a later, very welcome, patch. > Also, looking at > , > it seems that n2n might not be bit-for-bit reproducible. I agree this package has room for improvement. Hopefully, =E8=B7=AF=E8=BE= =89 can have a look at it. Regards, --=20 Nicolas Goaziou