unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 55220@debbugs.gnu.org
Subject: [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options.
Date: Sat, 21 May 2022 21:25:25 -0400	[thread overview]
Message-ID: <87ilpy9x4q.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220502111859.13605-4-othacehe@gnu.org> (Mathieu Othacehe's message of "Mon, 2 May 2022 13:18:59 +0200")

Hi Mathieu!

Mathieu Othacehe <othacehe@gnu.org> writes:

> Also factorize the --system and --target build options. Check that the passed
> system and target arguments are known platforms.
>
> * doc/guix.texi (Additional Build Options): Document the new --list-systems
> and --list-targets options.

This is a very welcome change, thanks a lot for tackling it!

[...]

> diff --git a/doc/guix.texi b/doc/guix.texi
> index 5399584cb0..22a8ee7d2d 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -12025,6 +12025,14 @@ Cross-build for @var{triplet}, which must be a valid GNU triplet, such
>  as @code{"aarch64-linux-gnu"} (@pxref{Specifying Target Triplets, GNU
>  configuration triplets,, autoconf, Autoconf}).
>  
> +@item --list-systems
> +List all the supported systems, than can be passed as @var{system}
                                   ^ that
> +argument.
> +
> +@item --list-targets
> +List all the supported targets, than can be passed as @var{target}
> +argument.

Likewise.

>  @anchor{build-check}
>  @item --check
>  @cindex determinism, checking
> diff --git a/guix/scripts/archive.scm b/guix/scripts/archive.scm
> index f8678aa5f9..991919773a 100644
> --- a/guix/scripts/archive.scm
> +++ b/guix/scripts/archive.scm
> @@ -93,14 +93,14 @@ (define (show-help)
>    (display (G_ "
>    -S, --source           build the packages' source derivations"))
>    (display (G_ "
> -  -s, --system=SYSTEM    attempt to build for SYSTEM--e.g., \"i686-linux\""))
> -  (display (G_ "
> -      --target=TRIPLET   cross-build for TRIPLET--e.g., \"armel-linux-gnu\""))
> -  (display (G_ "
>    -v, --verbosity=LEVEL  use the given verbosity LEVEL"))
>  
>    (newline)
>    (show-build-options-help)
> +  (newline)
> +  (show-cross-build-options-help)
> +  (newline)
> +  (show-emulated-build-options-help)

I have a bit of a problem with the "emulated" part of the name, as
--system not only targets emulated machines but also different native
machines of that architecture via offloading :-).  Perhaps,
'show-foreign-build-options-help', but I'm not sure that's an
improvement.

I've lost a bit focus for the remaining of the patch, but it LGTM.

Thanks again for tackling this so swiftly after it was brought up on an
issue.

Maxim




  parent reply	other threads:[~2022-05-22  1:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 11:17 [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options Mathieu Othacehe
2022-05-02 11:18 ` [bug#55220] [PATCH 1/4] platform: Introduce new platforms Mathieu Othacehe
2022-05-02 11:18   ` [bug#55220] [PATCH 2/4] platform: Add discovery support Mathieu Othacehe
2022-05-06 14:41     ` [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options Ludovic Courtès
2022-05-07 15:53       ` Mathieu Othacehe
2022-05-02 11:18   ` [bug#55220] [PATCH 3/4] ci: Do not rely on hardcoded cross-targets lists Mathieu Othacehe
2022-05-02 11:18   ` [bug#55220] [PATCH 4/4] scripts: Add --list-systems and --list-targets options Mathieu Othacehe
2022-05-06 14:54     ` [bug#55220] [PATCH 0/4] " Ludovic Courtès
2022-05-07 16:04       ` Mathieu Othacehe
2022-05-22  1:30       ` Maxim Cournoyer
2022-05-22  1:25     ` Maxim Cournoyer [this message]
2022-05-22 13:09       ` Mathieu Othacehe
2022-05-06 14:39   ` Ludovic Courtès
2022-05-07 15:50     ` Mathieu Othacehe
2022-05-06 14:37 ` Ludovic Courtès
2022-05-07 16:11 ` [bug#55220] [PATCH v2 0/6] " Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 1/6] platform: Introduce new platforms Mathieu Othacehe
2022-05-09 20:44     ` Maxime Devos
2022-05-22  1:39       ` [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options Maxim Cournoyer
2022-05-22 13:12         ` Mathieu Othacehe
2022-05-22 13:42           ` Maxim Cournoyer
2022-05-22 13:01       ` [bug#55220] [PATCH v2 1/6] platform: Introduce new platforms Mathieu Othacehe
2022-05-09 20:50     ` Maxime Devos
2022-05-22 13:02       ` Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 2/6] platform: Add discovery support Mathieu Othacehe
2022-05-09 20:58     ` Maxime Devos
2022-05-22  1:34       ` [bug#55220] [PATCH 0/4] Add --list-systems and --list-targets options Maxim Cournoyer
2022-05-22 13:06       ` [bug#55220] [PATCH v2 2/6] platform: Add discovery support Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 3/6] ci: Do not rely on hardcoded cross-targets lists Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 4/6] scripts: Add --list-systems and --list-targets options Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 5/6] platform: Add glibc-dynamic-linker field Mathieu Othacehe
2022-05-07 16:11   ` [bug#55220] [PATCH v2 6/6] linux: Remove system->linux-architecture procedure Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilpy9x4q.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=55220@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).