unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 55813-done@debbugs.gnu.org
Subject: bug#55813: autogen: Use guile-3.0
Date: Mon, 13 Jun 2022 21:02:51 -0700	[thread overview]
Message-ID: <87ilp3dh90.fsf@contorta> (raw)
In-Reply-To: <871qvwz0fe.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2064 bytes --]

On 2022-06-10, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> skribis:
>
>> Some relatively simply patches make autogen build with guile-3.0. Used
>> by both Debian an openSUSE, so already has a bit of field testing.
>>
>> I'm not 100% sure that it wasn't just dumb luck, but it seemed like
>> building autogen with guile-3.0 was more likely to build reproducibly.
>
> Nice.  :-)
>
>> It did require adding automake and autoconf to inputs, seeming to detect
>> that something changed since configure was generated. Not sure if that
>> could be avoided by being cleverer, or if that is an acceptible change.
>
> It could be avoided by changing just ‘configure’ (which this patch
> already does actually), but it’s fine either way.

Ah, that seems simpler, at least...

>> From 9745d65234b70115a07d324f5514b125ad97369a Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
>> Date: Sun, 5 Jun 2022 16:05:02 -0700
>> Subject: [PATCH 3/3] gnu: autogen: Build with guile 3.0.
>>
>> * gnu/packages/autogen.scm (autogen)[arguments]: Add 'support-guile-3.0 phase.
>>   [inputs]: Remove guile-2.2 and add automake, autoconf and guile-3.0.
>
> [...]
>
>> +             (substitute*
>> +                 "agen5/guile-iface.h"
>
> You can move that string to the previous line.

Done.

>> +             (substitute*
>> +                 (list
>> +                  "configure"
>> +                  "config/guile.m4")
>> +               (("2.2 2.0 1.8") "3.0 2.2 2.0 1.8"))))
>
> Here you should either modify ‘config/guile.m4’, in which case
> ‘autoreconf’ will have to run (that should be automatic), or modify
> ‘configure’, in which case the dependency on Autotools is unnecessary.
>
> The latter is a fine solution.

Ok, that seems like a smaller change, and still works, so went with that.

> OK with a change along these lines!

Thanks for the review!

Pushed as 3691e37eb14c5871d213646154b98f5aaa5dd2f1.


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

      reply	other threads:[~2022-06-14  4:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06  0:46 [bug#55813] autogen: Use guile-3.0 Vagrant Cascadian
2022-06-10 21:13 ` Ludovic Courtès
2022-06-14  4:02   ` Vagrant Cascadian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilp3dh90.fsf@contorta \
    --to=vagrant@reproducible-builds.org \
    --cc=55813-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).