unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Antero Mejr <antero@mailbox.org>
Cc: 55922@debbugs.gnu.org
Subject: [bug#55922] [PATCH] gnu: Add guile-termios.
Date: Thu, 16 Jun 2022 23:15:55 +0200	[thread overview]
Message-ID: <87ilp0joms.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220612222105.7257-1-antero@mailbox.org> (Antero Mejr's message of "Sun, 12 Jun 2022 22:21:05 +0000")

Hi Antero,

Looks like we’re almost done; some comments inline below.

Antero Mejr <antero@mailbox.org> skribis:

> * gnu/packages/guile-xyz.scm (guile-termios): New variable.

Note that all the relevant variables should be listed here.

> +(define-public guile2.0-termios
> +  (package
> +    (inherit guile-termios)
> +    (name "guile2.0-termios")
> +    (native-inputs (list guile-2.0))))
> +
> +(define-public guile2.2-termios
> +  (package

Unless there really is a need for them, you can drop them.  It’s
reasonable to assume 3.0 as the default for new code.

> +(define-public guile-tap
> +  (package
> +    (name "guile-tap")
> +    (version "0.4.6")

Could you make it a separate patch, and also remove the 2.0/2.2
variants?

By convention we usually add one package per patch:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

Thanks in advance!

Ludo’.




  reply	other threads:[~2022-06-16 21:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 10:04 [bug#55922] [PATCH] gnu: Add guile-termios Antero Mejr via Guix-patches via
2022-06-12 15:47 ` Maxime Devos
2022-06-12 22:21 ` Antero Mejr via Guix-patches via
2022-06-16 21:15   ` Ludovic Courtès [this message]
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
2022-06-16 21:53   ` [bug#55922] [PATCH 2/2] gnu: Add guile-tap Antero Mejr via Guix-patches via
2022-06-17 20:53   ` bug#55922: [PATCH] gnu: Add guile-termios Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilp0joms.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=55922@debbugs.gnu.org \
    --cc=antero@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).