unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christine Lemmer-Webber <cwebber@dustycloud.org>
Cc: 56204@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#56204] Add guile-goblins
Date: Mon, 27 Jun 2022 12:22:31 +0200	[thread overview]
Message-ID: <87ilomiexk.fsf@gnu.org> (raw)
In-Reply-To: <87edzbjl2h.fsf@dustycloud.org> (Christine Lemmer-Webber's message of "Sun, 26 Jun 2022 15:09:42 -0400")

Hi,

Christine Lemmer-Webber <cwebber@dustycloud.org> skribis:

> #+BEGIN_SRC diff
> diff --git a/Makefile.am b/Makefile.am
> index b8d4944..b056337 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,7 +32,7 @@ EXTRA_DIST = $(SOURCES) $(NOCOMP_SOURCES)
>  GUILE_WARNINGS = -Wunbound-variable -Warity-mismatch -Wformat
>  SUFFIXES = .scm .go
>  .scm.go:
> -	$(AM_V_GEN)$(top_builddir)/pre-inst-env $(GUILE_TOOLS) compile $(GUILE_WARNINGS) -o "$@" "$<"
> +	$(AM_V_GEN)$(top_builddir)/pre-inst-env $(GUILE_TOOLS) compile $(GUILE_TARGET) $(GUILE_WARNINGS) -o "$@" "$<"
>  
>  SOURCES = goblins.scm \
>            goblins/ocapn/crypto-stubs.scm \
> #+END_SRC
>
> Should that be sufficient?

Yes, that LGTM, provided GUILE_TARGET is properly computed, like in
Guile-Gcrypt’s ‘configure.ac’.

Thanks,
Ludo’.




  parent reply	other threads:[~2022-06-27 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 21:24 [bug#56204] Add guile-goblins Christine Lemmer-Webber
2022-06-24 21:57 ` Maxime Devos
2022-06-25  2:36   ` bug#56204: " Christine Lemmer-Webber
2022-06-25  9:32 ` [bug#56204] " Maxime Devos
2022-06-25 21:46   ` Ludovic Courtès
2022-06-26 19:09     ` Christine Lemmer-Webber
2022-06-26 20:50       ` Maxime Devos
2022-06-27 10:22       ` Ludovic Courtès [this message]
2022-06-25 21:49 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilomiexk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=56204@debbugs.gnu.org \
    --cc=cwebber@dustycloud.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).