From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8IhGJxbEamM0XAAAbAwnHQ (envelope-from ) for ; Tue, 08 Nov 2022 22:03:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YHBUJhbEamO50gAAG6o9tA (envelope-from ) for ; Tue, 08 Nov 2022 22:03:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E43726A40 for ; Tue, 8 Nov 2022 22:03:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osVjw-0006dO-21; Tue, 08 Nov 2022 16:02:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osVjP-0006VU-4i for guix-patches@gnu.org; Tue, 08 Nov 2022 16:02:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osVjO-00076M-MU for guix-patches@gnu.org; Tue, 08 Nov 2022 16:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osVjO-0003Ie-HX for guix-patches@gnu.org; Tue, 08 Nov 2022 16:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59102] [PATCH 2/2] gnu: Add mogan. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Nov 2022 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 59102@debbugs.gnu.org Received: via spool by 59102-submit@debbugs.gnu.org id=B59102.166794129112647 (code B ref 59102); Tue, 08 Nov 2022 21:02:02 +0000 Received: (at 59102) by debbugs.gnu.org; 8 Nov 2022 21:01:31 +0000 Received: from localhost ([127.0.0.1]:38298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osVis-0003Hv-Kb for submit@debbugs.gnu.org; Tue, 08 Nov 2022 16:01:30 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:38631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osViq-0003Hd-3e for 59102@debbugs.gnu.org; Tue, 08 Nov 2022 16:01:28 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 3A6BF24000B; Tue, 8 Nov 2022 21:01:18 +0000 (UTC) From: Nicolas Goaziou References: <20221107105827.10327-1-all_but_last@163.com> <20221107105827.10327-2-all_but_last@163.com> Date: Tue, 08 Nov 2022 22:01:18 +0100 In-Reply-To: <20221107105827.10327-2-all_but_last@163.com> (Zhu Zihao's message of "Mon, 7 Nov 2022 18:58:27 +0800") Message-ID: <87iljpkvoh.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667941398; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=tAeL7TOhA2VCLtfmDEPh567jZ4zEA+JYmB7dj5LO5ik=; b=n8yC91zu5rLB9g9/ubd3SzYynIijXChje24QJejsw0PmSdvoDekgdqS8I3Ft9mbl7IZ9fA 4gs4wj003sKUHlV/DMuNj36+kezjirwyyaSj3LH0bI9q1KOAFHNU5jeMAQjeWECioTJ4Zl j4t3nECgXMgG4YXoxQ1S4KfKFzn0ePRJIBYlhklWUt/OVE8vbfDw5CfgOUsX6M8TpvpqsK 2hXOradS54uYTLLAzHn3mjnRDy0MBvwWlwdsDl7I7hVwbwdfNH0RVpgiirYFEmVcrheTEg O474fn+sDWv4q//OhkqGVqJb76FOLwmBShhQoOjxtx6EiDfuF+jYW1nUyuUoMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667941398; a=rsa-sha256; cv=none; b=GvatWPjkhXIUsUZKeVAs1q4PJjLCPmPJdl2fWYP5fACSmoQk4dr7VZVPYP3tYR+IuXflXX rxD0i8p6RMX1tlH1W53RNX5whMdD4I3Xhd2v/QORt/MHBy4bVcwOEh2rvRKroZEM/vm1eA Ah/6tXCaueSkFDHEPsBmxRw64tEge4eXbCiEp69Q0b/+cWbTeF1YYLYqQF80MLXgZEPGXe UN0b3/hXKfMch5Dr4jqmmCxBws19mLnkxVZmcODnq9z0PMCd+//fNGCoaUDq60UuLmkrC2 4xxWpUUrnXkKYew5Df1fO/SBm/mGN52KzXM81gLw6MbMGn4rKr4uhgdgZK/OMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.62 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2E43726A40 X-Spam-Score: -1.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: upAyBZRHixAx Hello, Zhu Zihao writes: > * gnu/packages/text-editors.scm (mogan): New variable. Thank you. I applied the first patch of the set. Some comments about this one follow. > + (arguments > + (substitute-keyword-arguments (package-arguments texmacs) > + ((#:phases orig) > + #~(modify-phases #$orig > + ;; The non-deterministic compression issue is solved in Mogan. > + (delete 'gzip-flags))))) Unlike TeXmacs, Mogan ships with tests. Could you also run them? > + (synopsis "Structural editor delivered by Xmacs Labs") I don't think the ads is warranted here. Maybe "Scientific text editor" is better. > + (description > + "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is > +make everyone to enjoy it fluently and develop new feature for everyone to learn > +and create science and technology.") This description is not very descriptive. I don't have any good idea, the repository is not very helpful for that matter. At a minimum, I suggest to remove "created by Xmacs Labs" and separate sentences with two spaces. The second should also be replaced. > + (home-page "https://gitee.com/XmacsLabs/mogan"))) Could you move home-page above synopsis? Regards, -- Nicolas Goaziou