From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Zhu Zihao <all_but_last@163.com>
Cc: 59102@debbugs.gnu.org
Subject: [bug#59102] [PATCH 2/2] gnu: Add mogan.
Date: Tue, 08 Nov 2022 22:01:18 +0100 [thread overview]
Message-ID: <87iljpkvoh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221107105827.10327-2-all_but_last@163.com> (Zhu Zihao's message of "Mon, 7 Nov 2022 18:58:27 +0800")
Hello,
Zhu Zihao <all_but_last@163.com> writes:
> * gnu/packages/text-editors.scm (mogan): New variable.
Thank you. I applied the first patch of the set. Some comments about
this one follow.
> + (arguments
> + (substitute-keyword-arguments (package-arguments texmacs)
> + ((#:phases orig)
> + #~(modify-phases #$orig
> + ;; The non-deterministic compression issue is solved in Mogan.
> + (delete 'gzip-flags)))))
Unlike TeXmacs, Mogan ships with tests. Could you also run them?
> + (synopsis "Structural editor delivered by Xmacs Labs")
I don't think the ads is warranted here. Maybe "Scientific text editor"
is better.
> + (description
> + "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is
> +make everyone to enjoy it fluently and develop new feature for everyone to learn
> +and create science and technology.")
This description is not very descriptive. I don't have any good idea,
the repository is not very helpful for that matter. At a minimum,
I suggest to remove "created by Xmacs Labs" and separate sentences with
two spaces. The second should also be replaced.
> + (home-page "https://gitee.com/XmacsLabs/mogan")))
Could you move home-page above synopsis?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-11-08 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 10:58 [bug#59101] [PATCH 1/2] gnu: texmacs: Use G-expression Zhu Zihao
2022-11-07 10:58 ` [bug#59102] [PATCH 2/2] gnu: Add mogan Zhu Zihao
2022-11-08 21:01 ` Nicolas Goaziou [this message]
2022-11-23 10:42 ` Zhu Zihao
2022-11-26 11:03 ` bug#59102: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iljpkvoh.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=59102@debbugs.gnu.org \
--cc=all_but_last@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).