[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[jgart via Guix-patches via]

* gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
[native-inputs]: Add python-numpy.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a6b1c7e27e..0968f1477f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29153,7 +29153,7 @@ (define-public python-pudb
                     (lambda* (#:key tests? #:allow-other-keys)
                       (when tests?
                         (invoke "pytest" "-vv")))))))
-    (native-inputs (list python-pytest python-pytest-mock))
+    (native-inputs (list python-pytest python-pytest-mock python-numpy))
     (propagated-inputs (list python-jedi python-pygments python-urwid
                              python-urwid-readline))
     (home-page "https://documen.tician.de/pudb/")
-- 
2.38.1

[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]


jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
> [native-inputs]: Add python-numpy.
> ---
>  gnu/packages/python-xyz.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What I'm missing here is why you're making the change? It looks to me
that the package builds without python-numpy?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[jgart via Guix-patches via]

On Mon, 21 Nov 2022 12:10:08 +0000 Christopher Baines <mail@cbaines.net> wrote:
>
> What I'm missing here is why you're making the change? It looks to me
> that the package builds without python-numpy?

Hi,

Does test_get_stringifier currently pass or get ignored in the pudb
package's check phase?

https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L28

I'll check later today and report back.

[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[jgart via Guix-patches via]

On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart@dismail.de> wrote:
> I'll check later today and report back.

Oh, that test just passes an empty list if numpy is not available:

https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32

Do we want to run that test with our packaged numpy on [np.float32(5), np.zeros(5)]?

all best,

jgart

[bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]


jgart <jgart@dismail.de> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <jgart@dismail.de> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]