From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SNR0HqvNoWMdBgAAbAwnHQ (envelope-from ) for ; Tue, 20 Dec 2022 15:58:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8GVzHavNoWMbYgAAG6o9tA (envelope-from ) for ; Tue, 20 Dec 2022 15:58:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A72D69B8 for ; Tue, 20 Dec 2022 15:58:51 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7dua-0002p4-6L; Tue, 20 Dec 2022 09:48:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7duV-0002o1-B3 for guix-patches@gnu.org; Tue, 20 Dec 2022 09:48:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7duV-000330-30 for guix-patches@gnu.org; Tue, 20 Dec 2022 09:48:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7duU-0005OU-MH for guix-patches@gnu.org; Tue, 20 Dec 2022 09:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Dec 2022 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60014 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 60014@debbugs.gnu.org, mirai@makinata.eu Received: via spool by 60014-submit@debbugs.gnu.org id=B60014.167154764220562 (code B ref 60014); Tue, 20 Dec 2022 14:48:02 +0000 Received: (at 60014) by debbugs.gnu.org; 20 Dec 2022 14:47:22 +0000 Received: from localhost ([127.0.0.1]:45280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dtq-0005La-2i for submit@debbugs.gnu.org; Tue, 20 Dec 2022 09:47:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7dtn-0005LU-IV for 60014@debbugs.gnu.org; Tue, 20 Dec 2022 09:47:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7dth-000302-Fg; Tue, 20 Dec 2022 09:47:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ZPRGVSPqn/sBzq4f4gI2HAPMs1uQ7T3/6xPNba//yeQ=; b=c4i6DX17IQ0+95x1YP31 BTGmSj+6+iEJ/dDHu2ImX4Z2zAB8cZ865uV63PH+vO4JbQAxSPczMHzRSCYhHP/Rv7R9yFG7W4TQW hoAmoLlWl6gYcbBDNRdyu9yBUhiBae9gbzsiTSfXFcHNgTWU6rfHxvpUkg9lJHh1lbeQUcEwGG7TP 5KQJtgDkGsMvkAqQcS6bJiOkR1tVhdF8tMH9Hj2Nm4zbbhCL6fMnmkXW9apNCEd1hH/OVCwpyTcCB axLqCEkeElBAIpY8cwCMWq5DxsvwnjiB+8hxAlPME6MFf2tdaW1XSbnIPXjY1+WvKxGypwDZIJxeS L5ja8ERG8Qg74Q==; Received: from [193.50.110.60] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7dth-0005ee-0K; Tue, 20 Dec 2022 09:47:13 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> <87k02wfjk5.fsf@jpoiret.xyz> Date: Tue, 20 Dec 2022 15:47:10 +0100 In-Reply-To: <87k02wfjk5.fsf@jpoiret.xyz> (Josselin Poiret's message of "Mon, 12 Dec 2022 21:34:02 +0100") Message-ID: <87ili66sk1.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=c4i6DX17; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671548331; a=rsa-sha256; cv=none; b=aqrfFS5aUMl8a1LYFW/AEsR+QDiUJXKMK9X7k0zEjcVtpKVYl5XtNW2+wZs0/VY22VMXbc jwwE1pHBZMrJLzXMCFR8O1L7Y3QGifT8IYe+ED2LPsTZRK0IV5SwkyLscpvGZel4kvpXnZ Du1hirfM9BcDvpyU8dJkItpIwBbEVH15RwDDNIG/w1AYvox+6NePr6Bk6YWRz5h3nHPdWT UM3Mz+9EjcsPdfwzzsyDsMWBRegjS1F+9jcjeGz4iQBJwQ4c5mCKsJgFhXr9y+mrPIyu91 fk4nei/zPN+rgjljkrjfRW8yD8juOjPItwDO2GjBLiWvPvwSHGSCcTX7/PCp7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671548331; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZPRGVSPqn/sBzq4f4gI2HAPMs1uQ7T3/6xPNba//yeQ=; b=pNaM5qRJ7IHv3I1WcXdkzJWMn0NA5boFsDCRJzoWj/7cnJk+Ok8nziGo6UbQ2gJcZmXJKF 2WcMrjPY3tLE7/Z8SNJxjSdAn8M7VsBh3XGYQBPjuXGH4pN/aQusYU35MKKfL0uClcj9sb HhfQxXLnoqw7SXMDT5GojOoKXVb1B81olZweXLXBmWPkul30GJjZS99+rnecytKPA7I4dM G217oJFJl0GbCIYb9vupT7Jthu0iTSEjjtlYOUvxAVFVT2J2JT4cXD9LpXYDtWrpxwFfMa h2P6rN/qpP/6RayqKRnQT0y3R431gJuIhkm9x3+ycV2dQ9if4EqdA2khAlXZkA== X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=c4i6DX17; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -4.69 X-Spam-Score: -4.69 X-Migadu-Queue-Id: 2A72D69B8 X-TUID: HvzMFHMqwKB3 Hi, Josselin Poiret skribis: > Is this patch related to some specific problem you're running into? I > personally would prefer keeping the special file interface as-is, and > not mix two different kinds of entries: lists with 2 elements, and > pairs. That would avoid having to manage even more edge-cases down the > line if some more processing is needed. I agree. This is a public-facing interface so we should keep it as-is; extending it to support pairs in addition to two-list elements would likely bring confusion and bugs. I=E2=80=99m not entirely sure why we settled on two-list elements rather th= an pairs back then, but I think it=E2=80=99s OK. Closing? Ludo=E2=80=99.