From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yEL3B76G4mM3jAAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 18:13:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yPX0Br6G4mP0NwAAG6o9tA (envelope-from ) for ; Tue, 07 Feb 2023 18:13:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFDD03BC1E for ; Tue, 7 Feb 2023 18:13:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPRWi-000178-U4; Tue, 07 Feb 2023 12:13:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPRWh-00016Z-4r for guix-patches@gnu.org; Tue, 07 Feb 2023 12:13:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPRWg-0007GK-Pl for guix-patches@gnu.org; Tue, 07 Feb 2023 12:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPRWg-00029c-Lf for guix-patches@gnu.org; Tue, 07 Feb 2023 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60902] [PATCH 06/25] gnu: Add go-github-com-jba-templatecheck. Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60902 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60902@debbugs.gnu.org Cc: paren@disroot.org X-Debbugs-Original-To: "( via Guix-patches" via X-Debbugs-Original-Cc: "\(" , 60902@debbugs.gnu.org Received: via spool by 60902-submit@debbugs.gnu.org id=B60902.16757899618243 (code B ref 60902); Tue, 07 Feb 2023 17:13:02 +0000 Received: (at 60902) by debbugs.gnu.org; 7 Feb 2023 17:12:41 +0000 Received: from localhost ([127.0.0.1]:53898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPRWL-00028t-DA for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:12:41 -0500 Received: from mail-il1-f180.google.com ([209.85.166.180]:45024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPRWI-00028R-6e for 60902@debbugs.gnu.org; Tue, 07 Feb 2023 12:12:40 -0500 Received: by mail-il1-f180.google.com with SMTP id n2so2837117ili.11 for <60902@debbugs.gnu.org>; Tue, 07 Feb 2023 09:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0l/GmMUZJyczreLxIbSiKgpxRWNSAsoHQEEjD5z5jLA=; b=UQnH5eRYeJ9FRv62RSfIBj92+TMc1f31Vwl2FaNInZd40jjfFAaNeIiP66y3r/8ioK sYFb3zP4+8RspHoly2rHXFn6RUGDKAV07KWcZCf5gU0fvfkWOmFkIg0yQ+59/0oak3kd wTrNMOCoXDz4jTc9afjPqyjs/OvXhtzF3XfYE+W63NobD4OyZcrM2ywkLBi1aUU3O1gD Y1KOnkBT+pKKReY3EdVYpwG1qkcdiZPUdz3MmCMQMlNOV2UpuWf78SMYriGyRlAnMQdO Ha/A0URKMFjbbImEdGxar9LRUkJ8wSDBQtBEXiLO8kirCgYO+iZDSO9nmjKzUpzdQs9w fnaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0l/GmMUZJyczreLxIbSiKgpxRWNSAsoHQEEjD5z5jLA=; b=2sJsfoaMu1biI4cCcQI/O0Jfb/J8xZeVM4zfWLHCWJVa3i9u0xIYYPzJeHp6rbW0QZ 3zkk0MaM7eWmIpS5YQvLr0PJVj8NxQ5R0WKURgF1gyVhdsaDLb/qVo1Oyc1z3FVv2doE IU/HadZZI6caVsVsqZSQsSX0J/ZvkIk6kYBONdnvAbxiGlIRid5JHi/M9hFQtmmjpGyk yHHUBCuxIBzlBlUs1ZLP7KYf19e3lSexCsu4yLzMfBxg7fO0Ke9CwD2K15BNVI43C3/7 Rj4uqTmuiZ22Nswrkx8J2+xydi0xch5C+VbMZdrvW8k7Zrw8j/3QZEo8PGX3WRd7OZ66 fHOA== X-Gm-Message-State: AO0yUKUz63CdiWuoRhDrcP75ilw0gOi54M6dYdrM6T3264x7ITWSkBM9 VoaZPS2MKTEnMw/2MCmCtNw= X-Google-Smtp-Source: AK7set+8ZEp2ARY37D6ZU1XGJomNOTsoLb+EljILw7x7SSDNod5yq7mVzh5IEHKpnEkRE7QXknwhuA== X-Received: by 2002:a05:6e02:1906:b0:310:fad7:e1ca with SMTP id w6-20020a056e02190600b00310fad7e1camr4851576ilu.24.1675789952606; Tue, 07 Feb 2023 09:12:32 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id j6-20020a02cb06000000b0039e8f997ad6sm4439392jap.32.2023.02.07.09.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 09:12:32 -0800 (PST) From: Katherine Cox-Buday References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-7-cox.katherine.e@gmail.com> Date: Tue, 07 Feb 2023 10:12:31 -0700 In-Reply-To: (guix-patches@gnu.org's message of "Mon, 06 Feb 2023 22:07:44 +0000") Message-ID: <87ilgdxuv4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UQnH5eRY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675790013; a=rsa-sha256; cv=none; b=EZMPYipCUoaMUQMr8WVso6VTH4Z3V1hqmLcKvWFqcTbZ8sDaKcHbyEaQ8tLFe3+XqHMhp7 YKA8Bt+yDQacBUvPK9uFqs5s01gYRM8C0JqSt9ieSLyEDKwppXXM70HnCdF72238stjXqG 08yT9kLV8sNXFu8M6tLIt2D6W7vBvcRwqv+WIO3wuyneFnHb/jYpdcC5I+TuH45sJRLMFv iT2NEaM85itiEEEV2Eh1ziOyb/sZnYARZ5zwAWb2KvAl0rgI4A7iUtESvXkzyBPbIu/pXe I/BWrYoko/C7BwCe4ztlJllVZgI4WMeNQjzAJ8CbdElb4VM6w6zGdL+XW5ZSEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675790013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=0l/GmMUZJyczreLxIbSiKgpxRWNSAsoHQEEjD5z5jLA=; b=f5wMN0QBoEUrcmWgAbsOp6XNiVrCawLgls9qbr99Kzz5gjBgS/AGMlgYUfHZeL7qSXJHHs iyrHA+j2l0jM7OOk4CYuGAk7FnCxIUk1pTVPPTZF5sJmAO/lN/knYLVIjiEoyaPlFT6vEf L8UzQGcfzDjoaRszglwOv3+8SN9bpVqJeWjbXhMYlFyL3r4VwW3uh+Rmlq3jQ5Cx8jL3zT eNcwp8ZTusqH9U2xEPU1lCaRYJeRpb4AMe9Ux0m+UbQnQ4H4gTKBaxn9STzwg2h73HV09P 5TOQq4nKLaTUitNZDgpmw1PucSut5lXTjbwh+5BN3ijB4ScLLoS73Y7EIH5szQ== X-Migadu-Queue-Id: DFDD03BC1E X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UQnH5eRY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -2.99 X-Spam-Score: -2.99 X-TUID: 3JZe5chmm7Zo "( via Guix-patches" via writes: > * gnu/packages/golang.scm (go-github-com-jba-templatecheck): New variable. > >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm > >> @@ -8541,6 +8541,33 @@ (define-public go-github-com-jba-printsrc > >> + (synopsis "Checks Go templates for problems") > > s/problems/errors/ Upstream's synopsis uses the word "validity". I think I probably pulled the synopsis from the first sentence of upstream's description, which uses the word "problems". For future reference, would something like this really hold up a merge? >> + (description >> + "Package templatecheck checks Go templates for problems. It can detect >> +many errors that are normally caught only during execution. Use templatecheck >> +in tests to find template errors early, and along template execution paths >> +that might only rarely be reached.") > > (description > "This package provides a Go library for checking Go templates for errors, > including many errors normally caught only during execution.") Can you give more general guidance on what a description should have? I can't infer any general rules from the reviews you've given, other than maybe you are suggesting shorter descriptions. But the manual says: Descriptions should take between five and ten lines. So I think my inference is probably not correct. >> + ;; MIT > > Don't bother with the comment here :) No? I like knowing what license things are! But if this is a style thing, I can start leaving them off. -- Katherine