unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 64151@debbugs.gnu.org, Christopher Baines <mail@cbaines.net>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#64151] [PATCH] etc: Stop making sendemail behave strangely.
Date: Thu, 06 Jul 2023 11:49:25 -0400	[thread overview]
Message-ID: <87ilaxyr96.fsf@gmail.com> (raw)
In-Reply-To: <87ilb1qqud.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Mon, 03 Jul 2023 11:36:26 +0200")

Hi Ludo,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
>
>> Even with such a hypothetical --exclude-whomever switch added, I'd
>> argue that it is wrong to magically install this configuration without
>> any user interaction.
>
> Maybe that’s the main grief: that the new config was suddenly installed
> without fellow hackers realizing it (I, for one, wondered initially what
> magic made ‘git send-email’ Cc: all my friends :-)).
>
> Perhaps one way out is to suggest it in the manual without installing it
> automatically?  WDYT, Maxim?

I still think it has more value by being automatically installed, as
that way the pre-push hook that prevents unsigned commit is also
configured automatically, and new contributors would be likely to not
have it configured (by having missed it from the manual).

I see this similar to the .dir-locals.el file that automatically setups
(there's a prompt, but its design forces you into accepting it or being
repeatedly bothered ad aeternam).

If there are concrete issues with it, I think we should a) report them
and b) look into fixing them.

> (Independently of that, we’ll have to discuss patch review again.  We
> believed one problem was that potential reviewers wouldn’t notice
> patches in their area.  That’s arguably no longer the case, yet this
> hasn’t had any noticeable effect in terms of review activity.  How
> should we approach that?)

The teams are still nascent, and it's summer time.  I think we need to
give it some time and encourage more people to join or create new teams
and get familiar with the recently introduced/documented branch-based
updates :-).

-- 
Thanks,
Maxim




  reply	other threads:[~2023-07-06 15:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-18 11:49 [bug#64151] [PATCH] etc: Stop making sendemail behave strangely Christopher Baines
2023-06-25 21:06 ` Ludovic Courtès
2023-06-26 14:36   ` Maxim Cournoyer
2023-06-27 19:26     ` Liliana Marie Prikler
2023-06-28  1:14       ` Maxim Cournoyer
2023-06-28  4:30         ` Liliana Marie Prikler
2023-07-01  3:03           ` Maxim Cournoyer
2023-07-01  5:50             ` Liliana Marie Prikler
2023-07-01 16:03               ` Maxim Cournoyer
2023-07-03  9:36       ` Ludovic Courtès
2023-07-06 15:49         ` Maxim Cournoyer [this message]
2023-07-08 17:16           ` Liliana Marie Prikler
2023-07-10  4:24             ` Maxim Cournoyer
2023-07-10 21:21               ` Ludovic Courtès
2023-07-11  4:28                 ` Liliana Marie Prikler
2023-07-14 13:21                   ` Ludovic Courtès
2023-07-14 13:52                     ` Liliana Marie Prikler
2023-07-14 14:12                       ` Maxim Cournoyer
2023-07-14 13:59                     ` Maxim Cournoyer
2023-07-17 13:02                       ` Christopher Baines
2023-07-17 16:43                         ` Maxim Cournoyer
2023-09-06  4:49                           ` bug#64151: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilaxyr96.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=64151@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).