[bug#64151] [PATCH] etc: Stop making sendemail behave strangely.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

Hi Chris,

Christopher Baines <mail@cbaines.net> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>>> Mumi could also display a tag based on this and let people select only
>>> issues relevant to a specific team.  That would be an improvement over
>>> what we have.
>>>
>>> Thoughts?
>>
>> I am still not convinced something deserves to be changed here; the
>> problems reported so far, unless I'm missing something, were:
>>
>> 1. It's weird that send-email cause people to be CC'd itself
>> 2. It can be confusing when a larger series touches multiple teams
>>
>> I think 1. mostly results from the initial surprise that send-email now
>> behaves that way, but I don't see how it's a bad behavior to reach out
>> to team members automatically.  The process being automated should yield
>> the same result as if a user called the etc/teams.scm script and placed
>> the --add-header arguments themselves.
>>
>> 2. Is more of an edge case.  I think if we have a policy of adding a
>> LGTM *per patch* or 'LGTM for whole the series' it'd solve the immediate
>> concern.  Having a X-Guix-Team as proposed by Ludo *also* added could
>> provide a bit more context in doubt.
>>
>> I'd be interested to hear back from Chris, which originally opened
>> issue, in light of the above.
>
> On the 2nd point above, I've also felt the effects of the other side,
> where it's irritating that mail that used to be on mailing lists has
> moved in to my inbox. I can still automatically file away the initial
> email, but then people typically CC me directly when replying.
>
> I'm obviously OK with this when people directly want my input or if I'm
> already involved in the conversation, but this CC thing has extended
> that to most/any patch submissions that are detected overlapping with
> teams I'm in.

Notifying team members of a patch touching their scope is the intended
behavior of the teams mechanism.

> Maybe this is just because of the email address I used for teams. I've
> now gone and changed this from mail@cbaines.net to guix@cbaines.net,
> which comes to the same place, but I'll hopefully be able to use the
> different address to separate out the emails appropriately.

Of course this behavior now being automated, if you are part of many
teams, the amount of emails reaching your inbox may be higher than it
used to be.  If the flux is too large for you to process, I'd recommend
you review and perhaps trim your current teams subscription.  One of the
expected side-effect of notifying team members with etc/teams.scm is
that it should improve reviews.  Keeping our team scopes more focus (and
encouraging active participation of new team members) should help reduce
the load in the long run.

-- 
Thanks,
Maxim