From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oHAcCgd+7mRdvQAAG6o9tA:P1 (envelope-from ) for ; Wed, 30 Aug 2023 01:23:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oHAcCgd+7mRdvQAAG6o9tA (envelope-from ) for ; Wed, 30 Aug 2023 01:23:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EABC161F44 for ; Wed, 30 Aug 2023 01:23:50 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=UrZZdcMH; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693351431; a=rsa-sha256; cv=none; b=qYYz+KtGIDB7dnUTwGoxs0uzGrEsZYc6ujb+Y6n5w9DWwe/GZ3E3kGolHiSPTMxOT9OBRE lYvRfgNlCTcKNVHvlcSOtIhS5Xt8VTRzrUqmpuR4g8PiFeV4f4RSCK0OKokVKD2FjDcUQG imB6JYv0PamFW4wJIVoo6+lq3+H+NGZZ8swevUAWhzlky7llyysMlkk4XONHib2/1L4Us+ BU2pFKCrVXroXX2bf2d1sq2Wyr4uwezfaHzsE2yCnXvhDBw9RunRXwisNHy4puVtj3JTQf TQuNz23Acgo5S6x1vEu6JS+C4D3iDBis2dKUqRzR4Upje0mwd6T5DoSRUsiZHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=UrZZdcMH; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693351431; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/9U4xOfTCivrxUS5nW9OK7DfCCES+QnE8IVa/6d1zmE=; b=IO91PZ9Dbbtja2WWS/o+t53sQE8/lPrVOP4LUxq9eKwF0B1e/4yip/t1B9rlYKNr+BF7KM 3iUaC5py14lFAYPnsuxyXdWBTstoWzy11dzm6aWoId+OI+Rv3p75r5UFhXR70gGPkkiBjw BjZYgh+bUHeAnSQTi+8SaZ3HBrKcPZAhzE2m1ICiZhhsnA+DBrmKvUuRN7Fen1W64ypPfs DiK3b1WXgJN9py2e2gIuqd6iMaFMGCBlbmUiV+lADZKJplhbroZ5zCIchyCD0o2x0GjlRL zLImI+3APs6yAdUmwd/6pGxYGPz5s/iuJ+3wL1b4CHrKUAzZy2fUCQ6ubDTRTg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qb7n6-0000tX-Vw; Tue, 29 Aug 2023 19:06:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb7fj-0008QB-ES for guix-patches@gnu.org; Tue, 29 Aug 2023 18:58:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qb7fj-00055W-6d for guix-patches@gnu.org; Tue, 29 Aug 2023 18:58:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qb7fq-0002iR-7Q for guix-patches@gnu.org; Tue, 29 Aug 2023 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Aug 2023 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denis 'GNUtoo' Carikli Cc: Efraim Flashner , 64667@debbugs.gnu.org Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.169334994010432 (code B ref 64667); Tue, 29 Aug 2023 22:59:02 +0000 Received: (at 64667) by debbugs.gnu.org; 29 Aug 2023 22:59:00 +0000 Received: from localhost ([127.0.0.1]:51790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb7fo-0002iC-D7 for submit@debbugs.gnu.org; Tue, 29 Aug 2023 18:59:00 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:36400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qb7fi-0002ht-6Z for 64667@debbugs.gnu.org; Tue, 29 Aug 2023 18:58:59 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 97D2F1ADEE; Tue, 29 Aug 2023 15:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1693349917; bh=n1n84Cc3jd2t6evAHnELDgYaKsIp17IRjZHFpdaFXjw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UrZZdcMHRdVRmehAcLl7ztIzRtaPBA7W6bEj73xioCMhj+uAzCAcF4+DZTufP5xc2 m0aJbmb4M/M+VH4Dbjsx3pM98kmspkNHKhnGirGM0cGsELRsVarjRgeYoRkKTZ7it5 5OlX0DsCccH6UX9qIONPPhtad6IWD7WnhwXD6VHstZ4FCy4gftiJcOzg0dgq6FwQzI n+SXe6GUpG3/b5xuVmFFkV+eTbLrPTieIDsV3Ly3oiJ3tlxyoa+de/WVsKp4z+4uEf 5P68njBqW2N70isWLIG6pkbhPTUqZYn0vv/r+oHep9BveUKPtqBm13Yt7kDfOXvqV8 aTG63VJOre9Kg== From: Vagrant Cascadian In-Reply-To: <20230727054224.138476d6@primary_laptop> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> <87v8eh14mq.fsf@wireframe> <20230727054224.138476d6@primary_laptop> Date: Tue, 29 Aug 2023 15:58:33 -0700 Message-ID: <87il8xv4km.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: EABC161F44 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -3.32 X-Spam-Score: -3.32 X-TUID: Wx/qTNYB/LxJ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-07-27, Denis 'GNUtoo' Carikli wrote: > On Tue, 18 Jul 2023 11:00:45 -0700 > Vagrant Cascadian wrote: >> > + ;; Several tests fail >> > + ((#:tests? _ #f) >> > + #f) >>=20 >> Could you explain in more detail about the failing tests in the >> comment? Which tests? Are they testing things that are not valid in a >> grub-coreboot context? Is it not reasonable or not plausible to >> selectively disable only the failing tests? > I've looked into it, and the reason the test fails is similar than with > UEFI: many tests require to build a Coreboot image (and also to > build cbfstool which is available in Coreboot)[1]. > > And building Coreboot for qemu would require to deblob it first, and > simply using Libreboot for that doesn't work anymore because recent > versions don't deblob Coreboot and even ship nonfree software in the > releases. > > So at some point we will likely have some clean solution for that, but > it could take some time. > > In the meantime if the comment is changed for the following, would it > work for you? >> ;; TODO: Tests need a (deblobbed) Coreboot firmware for qemu. Still seems a bit brief, but I suppose it is not terrible. :) I might want to identify in the comment which tests need a coreboot image and which need cbfstool for example. If it is really involved, perhaps a link to a more detailed explanation, such as to a comment filed on this bug report. > Or do I really need to disable the failing tests[2]? Well... > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > GRUB 2.06: ./test-suite.log > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20=20=20=20 > # TOTAL: 80 > # PASS: 19 > # SKIP: 24 > # XFAIL: 0 > # FAIL: 37 > # XPASS: 0 > # ERROR: 0 Disabling all the tests means that you would miss out on at least 19 tests that currently PASS (but might someday fail, because they are actually presumably testing something)... Are all of the failures or skipped tests things that cannot reasonably be fixed, such as being unable to build a coreboot image or cbfstool? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZO54GQAKCRDcUY/If5cW qmGRAQCpfsZsbSwo9NVda0EgHd5A5IjGA07w+HONet6PIGoLoAD/fePNi7RUmxMY Q9Yf9y9PFuMpLgk280sYHBKKsjvElQs= =IcVM -----END PGP SIGNATURE----- --=-=-=--