unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "André A. Gomes" <andremegafone@gmail.com>
Cc: 66143@debbugs.gnu.org
Subject: [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741
Date: Mon, 25 Sep 2023 11:01:13 +0100	[thread overview]
Message-ID: <87il7y7efi.fsf@cbaines.net> (raw)
In-Reply-To: <87fs375jy2.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]


André A. Gomes <andremegafone@gmail.com> writes:

> Hi Guix,
>
> Please find the patch attached.  Thanks!

It seems like you've attached two patches? It's useful to just send one
patch per email, as lots of tooling expects that.

Looking at the first patch though, packaging anything but the latest
release shouldn't be the norm [1].

1: https://guix.gnu.org/manual/en/guix.html#index-version-number_002c-for-VCS-snapshots

You need to put the reasoning for updating these packages to these
specific commits in to some comments. Depending on that justification as
well, we need to decide whether to ship these versions in addition to
the latest releases, or as you're doing currently to replace the latest
releases with these snapshots.

What approach to take depends on the justification, e.g. if the latest
release is unusable or using it could be problematic, then replacing it
with a snapshot seems better, otherwise, we should create package
variants (e.g. emacs-slime-next) for these snapshots.

Does that make sense?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2023-09-25 10:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 20:51 [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741 André A. Gomes
2023-09-25 10:01 ` Christopher Baines [this message]
2023-09-26  9:16   ` André A. Gomes
2023-09-28 10:19     ` André A. Gomes
2023-10-20 19:46       ` André A. Gomes
2023-10-22 11:51         ` Guillaume Le Vaillant
2023-10-24  7:31           ` André A. Gomes
2023-10-24 12:40             ` bug#66143: " Guillaume Le Vaillant
2023-10-24 13:08               ` [bug#66143] " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il7y7efi.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=66143@debbugs.gnu.org \
    --cc=andremegafone@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).