From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wALCOcMnFWXtLgEAG6o9tA:P1 (envelope-from ) for ; Thu, 28 Sep 2023 09:14:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wALCOcMnFWXtLgEAG6o9tA (envelope-from ) for ; Thu, 28 Sep 2023 09:14:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AD87A541CB for ; Thu, 28 Sep 2023 09:14:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=ePuRSbC8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695885251; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8I8fU/IRtLBK7ZNdRoAx5nngec1NS9cqERlLdzxn5qc=; b=mT9vWLINHDsmMqKjhYdGiDLUQFxrBWst0FiA6KvdkZ7lcSCkMg1XwuzOFVcbhRorOTOE+X po2TUbTDT8YPelXZnnUmW0kYs7r4PfHQ0FSZcW3nJPl5QUPKCkL3myRmfb8l1XPbkwCK/8 htXUsXKLuK/9zk0icFLWm4+RvRMvhUmhrnHqiMivxg7xBrVaAkNhpwCJ35OnnKFI9zrDz3 xYNh0SgntbKMq0i5tda7dd51qlOU2J9Is3Wyd1GZIJKNWh187Wga5xzSb5ghgWOefWCdBe l2mElErZTFgGYtMuU3u4jdmDWhLLseQrpfqTQlF+egCWOcb+ONoHjTFCTHJbUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=ePuRSbC8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695885251; a=rsa-sha256; cv=none; b=K6vbBgvbfEuUIKQSQgHFWYdxXnEGvEx+TGQ99f087WwpFRLSYpoT7tPDrI+PZWqJ21m6Gq ujC2awGMMB6qAnSvhUVtN0xiucdvBNu8uImIBSGiQoXMc/g2Hy0VdqFv4LT9l6kVBcxnMi 1ui9dN6RcflY0lp5e4Tp9UoH0qr2X1VUzRwYRyJdtUHQTn+gzVHMpLZmZN6mrG9RUTN+Gs v5OFHH3Zv6NT4cqQjSsMPtp14MIPlR0/7hGd9R1rHtoUvImeEi2YaF8uHXkq8GOS/RfIy9 KJHo3QfTp459c9cKr57Y8Pd4dQAOw0d/dynF6KTykOJ2gLTgu8rdkNVMdflTbg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qllDa-0007BJ-IF; Thu, 28 Sep 2023 03:13:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qllDX-0007Ap-Vb for guix-patches@gnu.org; Thu, 28 Sep 2023 03:13:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qllDX-0008Q9-N8 for guix-patches@gnu.org; Thu, 28 Sep 2023 03:13:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qllDl-0007xu-ME for guix-patches@gnu.org; Thu, 28 Sep 2023 03:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65351] [PATCH v2 1/7] gnu: cgit: Make git-source a native input. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Sep 2023 07:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65351 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 65351@debbugs.gnu.org Cc: "\(" Received: via spool by 65351-submit@debbugs.gnu.org id=B65351.169588520930565 (code B ref 65351); Thu, 28 Sep 2023 07:14:01 +0000 Received: (at 65351) by debbugs.gnu.org; 28 Sep 2023 07:13:29 +0000 Received: from localhost ([127.0.0.1]:52900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qllDF-0007wv-BQ for submit@debbugs.gnu.org; Thu, 28 Sep 2023 03:13:29 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:48090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qllDB-0007wh-D7 for 65351@debbugs.gnu.org; Thu, 28 Sep 2023 03:13:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8I8fU/IRtLBK7ZNdRoAx5nngec1NS9cqERlLdzxn5qc=; b=ePuRSbC8uBmG3NekNjjeHocJeM MABPWLNxwaVv+1yC5JBvriAkVEu4/MKD5Wye2JlgB979gIEDlyroul4ksXWBEYoBpN0EHx42jPFrZ v7Vkiad2vI+FEknAXVzVtiKkVZv0o/B1qgxSN3n1r81LFK+o1cKUgW1AsUoRW9nv8egrwhUmZQFdd A8FeopdJ/fooeq9n35BnXeVk5q6ueOaFNRz5a+hQ9XgR9IACeST0EQoQJG6bh4/DUuGhz1PHlrTWQ Cjz4mgJzxKlrmF+gNQGV9clvZSjY8Bk4p+stjYJxBvGRCuKKaSIsul8/u6mf+g7Fm+OORXxHhh5FL VSqQ0apQ==; Received: from [192.168.2.1] (port=15561 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qllCq-000Rxq-28; Thu, 28 Sep 2023 08:13:05 +0100 From: Arun Isaac In-Reply-To: <8e6112265e2dbd774d5dc0b8c666aa7649ed3137.camel@gmail.com> References: <4a837cf5e2a54fae057bb983fb60b0bc9c997602.1693746463.git.arunisaac@systemreboot.net> <8e6112265e2dbd774d5dc0b8c666aa7649ed3137.camel@gmail.com> Date: Thu, 28 Sep 2023 08:12:55 +0100 Message-ID: <87il7u4vpk.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.10 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: AD87A541CB X-Spam-Score: -5.10 X-TUID: SP7GJWK5Xg5B Hi Liliana, Sorry for the long delay! Life got in the way. > This patch is broken and it doesn't appear to get fixed in 4/7. If you > want git-source to be in native-inputs, you need to use (or native- > inputs inputs). I'm not sure what you mean. I am able to build both cgit and cgit-pink on my machine. The QA system also agrees with me. https://qa.guix.gnu.org/issue/65351 > Most of these patches are not really atomic, depending on each other to > make sense. I'd instead possibly do the following: > 3 > [1, 2, 4, 5] squashed into a single commit > 6 > 7 I disagree. I do think these commits are atomic. Each one of these commits fixes a single independent problem with cgit that has no relevance to cgit-pink. Finally, the last commit adds cgit-pink. Note that there are already many commits in guix along similar lines. So, there is precedent. * gnu: cgit: Make git-source a native input. * gnu: cgit: Make bzip2, gzip and xz inputs. * gnu: cgit: Do not return #t from custom phases. * gnu: cgit: Use G-expressions. * gnu: cgit: Add bash-minimal to inputs. * gnu: cgit: Use cc-for-target. * cgit-pink gnu: Add cgit-pink. > In 7, you might want to use /bin/sh if the compatibility is meant for > stuff that actually lands in the store. /bin/sh doesn't work. I have tried. If I remember correctly, this is to do with how the SHELL_PATH gets substituted into generated scripts. Cheers!