From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id YKr3JfHF12VFVQAAe85BDQ:P1 (envelope-from ) for ; Thu, 22 Feb 2024 23:08:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id YKr3JfHF12VFVQAAe85BDQ (envelope-from ) for ; Thu, 22 Feb 2024 23:08:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=rCuS8eaH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708639729; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Rq3LkJCMETYsu5QWwdnJ1LlgTKewhCdPEmx/Z8Njt/s=; b=sKSWL/hac5FF1QyqCY+MLAokGjwetEpKj/8sVtEHGQnB42+wqc1ajhJd9Qh0yk7aVyjDXx +S9VdOM8SlwQPpL14ZgMaBoj1eQDfcV1BPo2dc8wOeMHw4xBTWH1zNuYUIXTgOALsYJhTq 98X8rVA7GWnfc4Nim8CPlj1IK72PVxuZ9nHGgWcojvON2Bciu8fZU+OelX190cg4/jWSXs ilCYgu0YOLx8IykEuDknAXxvqvmNSSi+TVM9ws5P3BXGHnA+211VZUH99qH9my7gqZYffX zU8hul9tt6eAcf5zgv2zZo/CXxEV+Yx+jg94NQLA2mDHQgF00jt6QUNAgGNCrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=rCuS8eaH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708639729; a=rsa-sha256; cv=none; b=J7jx2vXcShu6D3n2cpNkqyVp5VczzYmnsK1Q8M0oON3btTNre180EsYvNZUlW9NY8uVx1D 0bFP53NzYOhetc+k6a6dB+GQYgKr9LJUxLNMJ+jEuGtTwKuTvCaUbfvVXiQHQlAV4Tw4lr n4Tl0QJGg5mtNy44BlusXWld+zwMa8Hz987oFAtkKVtI5RHTRcTae4wWjura4pwq9+Xklj GoetB+fikah+Pg0nAEzhPKsfW4EVxvN8S43bmM6Vxz1pZIAqnqIZiL55it5WaRsZo7O3iO Hcej0moZtyoE4udUwQtMt9hGQI9F+QjIG5gtg4yUA2LtBejNje3t3WBxdcCRQg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 285AE5237A for ; Thu, 22 Feb 2024 23:08:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdHFB-0004JZ-L2; Thu, 22 Feb 2024 17:08:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdHF9-0004J6-Ii for guix-patches@gnu.org; Thu, 22 Feb 2024 17:08:39 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdHF9-0000b6-7m for guix-patches@gnu.org; Thu, 22 Feb 2024 17:08:39 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdHFV-0001zl-US for guix-patches@gnu.org; Thu, 22 Feb 2024 17:09:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69313] [PATCH] gnu: tlpui: Fix broken package. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Feb 2024 22:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69313 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Juliana Sims Cc: 69313@debbugs.gnu.org, Tobias Geerinckx-Rice , Wilko Meyer , Leo Famulari Received: via spool by 69313-submit@debbugs.gnu.org id=B69313.17086396947539 (code B ref 69313); Thu, 22 Feb 2024 22:09:01 +0000 Received: (at 69313) by debbugs.gnu.org; 22 Feb 2024 22:08:14 +0000 Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHEk-0001xW-0u for submit@debbugs.gnu.org; Thu, 22 Feb 2024 17:08:14 -0500 Received: from msg-4.mailo.com ([213.182.54.15]:44704 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHEh-0001x2-2a for 69313@debbugs.gnu.org; Thu, 22 Feb 2024 17:08:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1708639661; bh=rzuBJWK2XDcfqr+kU9AJyVWT58U7w8sUuAKa5K73aqs=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=rCuS8eaHqxPvg0XJw+bSCBr1AV4xfKQJqVfRVX0hQG6ZoeZXikhU6iEYjahjlymfH q7se0q5yB9Y4qUn7FEU1CkY4fzwzH1LeItaFs2wJ4FbgX0AGTHoJRKxE5lL1I/T86W 99aezj7ofRTY1Gv3GovDntoV5rrPy7A5OV2X/m4E= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 22 Feb 2024 23:07:40 +0100 (CET) X-EA-Auth: sUSsrVMsRsIIqoqWzb8tt+sHPsXL+gh3brcFfvHMMMdXDVkAHdRCjCmJ6aBxkaLHKhZL6L05ifkSPOoaQQL17VNdw9wxN7UpgDvKFrkNquQ= In-Reply-To: (Juliana Sims's message of "Thu, 22 Feb 2024 15:10:42 -0500") References: Date: Thu, 22 Feb 2024 23:07:25 +0100 Message-ID: <87il2gcfvm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.77 X-Spam-Score: -6.77 X-Migadu-Queue-Id: 285AE5237A X-Migadu-Scanner: mx13.migadu.com X-TUID: ifYqLj1vwNYM Hello, Juliana Sims writes: > * gnu/packages/linux.scm (tlpui): Fix broken package. Thank you. I think the commit message could be expounded a bit, e.g., * gnu/packages/linux.scm (tlpui)[arguments]: Fix location for "defaults.conf". > (add-after 'unpack 'set-absolute-locations > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((defaults.conf > - (search-input-file inputs "/share/tlp/defaults.conf")) > - (lspci (search-input-file inputs "/bin/lspci")) > - (lsusb (search-input-file inputs "/bin/lsusb")) > - (tlp-stat (search-input-file inputs "/bin/tlp-stat"))) > + (lambda _ > + (let ((defaults.conf #$(file-append tlp "/share/tlp/defaults.conf")) > + (lspci #$(file-append pciutils "/bin/lspci")) > + (lsusb #$(file-append usbutils "/bin/lsusb")) > + (tlp-stat #$(file-append tlp "/bin/tlp-stat"))) I'm a bit puzzled here: how does (search-input-file inputs "/share/tlp/defaults.conf") differ from #$(file-append tlp "/share/tlp/defaults.conf") ? And how does this relate to other changes in the patch (lsusb and lspci)? > (with-directory-excursion "tlpui" > (substitute* '("file.py" "settingshelper.py" "statui.py") > (("\"tlp-stat\"") > (string-append "'" tlp-stat "'")) > (("/usr/share/tlp/defaults.conf") > - (string-append "'" defaults.conf "'"))) > + defaults.conf)) OOC, would this single line suffice to fix the issue? On my side, this seems to be the case. Regards, -- Nicolas Goaziou