unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Steve George <steve@futurile.net>, ngraves@ngraves.fr
Cc: 67549-done@debbugs.gnu.org
Subject: bug#67549: [PATCH v2 0/2] Re: Add latexml
Date: Tue, 16 Apr 2024 23:03:07 +0100	[thread overview]
Message-ID: <87il0hufs4.fsf@cbaines.net> (raw)
In-Reply-To: <cover.1712871392.git.steve@futurile.net> (Steve George's message of "Thu, 11 Apr 2024 23:10:38 +0100")

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Steve George <steve@futurile.net> writes:

> Hi Nicolas,
>
> You sent this back in November. As I reviewed I noticed that there
> were a lot of propagated-inputs, so I extended your wrap phase and
> moved everything into inputs. Some of the magic of gexps is at the
> edge of my current understanding, so perhaps there's a better way to
> do this?
>
> Review:
>   * Move PERL5LIB propagated-inputs to wrap-program
>   * Update to new minor version
>   * Change to Git / enable tests
>   * functionality: tested with example
>   * checked with guix lint
>   * reroll to trigger QA build
>
> Nicolas Graves via Guix-patches via (2):
>   gnu: Add perl-image-size.
>   gnu: Add latexml.
>
>  gnu/packages/markup.scm | 117 +++++++++++++++++++++++++++++++++++++++-
>  gnu/packages/perl.scm   |  20 +++++++
>  2 files changed, 136 insertions(+), 1 deletion(-)

Thanks both, this looks good to me so I've gone ahead and pushed these
patches to master as 6a6dde505888bb1aff84bb02480f94312ac2989f.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      parent reply	other threads:[~2024-04-16 22:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 17:17 [bug#67549] [PATCH 0/2] gnu: Add latexml Nicolas Graves via Guix-patches via
2023-12-02 11:08 ` [bug#67549] [PATCH 1/2] gnu: Add perl-image-size Nicolas Graves via Guix-patches via
2023-12-02 11:08   ` [bug#67549] [PATCH 2/2] gnu: Add latexml Nicolas Graves via Guix-patches via
2024-04-11 22:10 ` [bug#67549] [PATCH v2 0/2] " Steve George
2024-04-11 22:10   ` [bug#67549] [PATCH v2 1/2] gnu: Add perl-image-size Steve George
2024-04-11 22:10   ` [bug#67549] [PATCH v2 2/2] gnu: Add latexml Steve George
2024-04-16 22:03   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il0hufs4.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=67549-done@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    --cc=steve@futurile.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).