From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iHhhL1PjfGas8AAAe85BDQ:P1 (envelope-from ) for ; Thu, 27 Jun 2024 03:58:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id iHhhL1PjfGas8AAAe85BDQ (envelope-from ) for ; Thu, 27 Jun 2024 05:58:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=bJSZ1lKT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719460691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wIXhuebS9ReqAoOON9tKnXP0XDpsRVVNpscr7oLJpjQ=; b=ZbRLYHLAx5iaMZcQXZ2gTUyNoDk9/bB77BU1+FlV984XmKK6UlY4aaiGNXOYrwmXuR3TwW hlLaCd8shVqZLYIH+MCtsLh+85pXN1qu2EggHHLk5iwfkBQ3cBl9AsYOUKoH7I+74eXf+1 SckAs/jDTXp5bOgYDX1UElZ3q63GxUcsAPeLtGFLCtT9RsEh7cRy2T/XZZ/khedShNSvp8 tFeqxCZ5v77BWD9y65ul7NaeJx8vlJawWsoJygMOvm4+J1aciGi9teqZZNxOmc4msbWsxK s83Hy2CfZBPHLLJfsoSYna0kit+lwNGahSKP8Mjh7BKLT1Z3rLL4dy92sfUKNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=bJSZ1lKT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719460691; a=rsa-sha256; cv=none; b=EXaz0y49DNuiM2H12zbYTUHOcatiszqKjuiEGpQL0aBOZcAaU5IM6z+xeiURW0T2nZLyFS SouwRrkSUh+MPeQrPJRc4kB27XX7BUwJ+l9EC3uEVcCCscYTuNYVvswpXtbNFBWjmTv9dO s+rBxS4wVdzhHHvhTWcZdQApadx5oMBG3wvJ250z6NTDW/2rcw7sYI1UY8BOJCQ04qguiW jUoV4ks84KnUqRnW/IZAUPchyvVOBKlni8f7rbP/1k6L6aOpPTRh8mHK1TflwzyL3RTB1i SLIGt+VGdlIz+GsB+LAnNXmFDK/J/0bVse8EZembXGKsDo5YBzQT5gK1DWYL6g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F3CA69E11 for ; Thu, 27 Jun 2024 05:58:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMgGn-0003M4-TP; Wed, 26 Jun 2024 23:58:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMgGm-0003Li-7f for guix-patches@gnu.org; Wed, 26 Jun 2024 23:58:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMgGl-0000JJ-Vx for guix-patches@gnu.org; Wed, 26 Jun 2024 23:58:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMgGo-0002tO-9y for guix-patches@gnu.org; Wed, 26 Jun 2024 23:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71639] [PATCHv2 0/5] Improve on restic-backup-service References: Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Jun 2024 03:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71639 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: paul Cc: 71639@debbugs.gnu.org Received: via spool by 71639-submit@debbugs.gnu.org id=B71639.171946063211054 (code B ref 71639); Thu, 27 Jun 2024 03:58:02 +0000 Received: (at 71639) by debbugs.gnu.org; 27 Jun 2024 03:57:12 +0000 Received: from localhost ([127.0.0.1]:40650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMgG0-0002sE-GB for submit@debbugs.gnu.org; Wed, 26 Jun 2024 23:57:12 -0400 Received: from mail-108-mta11.mxroute.com ([136.175.108.11]:33911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMgFy-0002s5-8C for 71639@debbugs.gnu.org; Wed, 26 Jun 2024 23:57:11 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta11.mxroute.com (ZoneMTA) with ESMTPSA id 19057d6feb300017a3.002 for <71639@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 27 Jun 2024 03:57:06 +0000 X-Zone-Loop: f9a11ce01b11d57660a63ad3192a6c1dffb440b41f14 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wIXhuebS9ReqAoOON9tKnXP0XDpsRVVNpscr7oLJpjQ=; b=bJSZ1lKTS6+vD34PbUbngbB5Ae NWSinVSWRKpjELNSyrD2YuhZirKY4MmIw5sdG7p3FnEuKm6/ouS4ChHb12Gc1lfvqvdQSvEKJlqqP vyVOzvBYGD/QrlbO1f0uJrIymgJeu/MgWOdJzkL/aKj0nylTBlWIz1ggFqtNgwYyS1OW4YcZd1IC8 vPLCO6sSOo1Hc2mTdSGJkxtFyc8tjTP/k6ezmoSMAcv8br1V0Jr2cVMFpn3T7KebTFN8onTivFsXN OCgZyyeVJiOXnTV1Nmn9JwXe/j2LEFuhq4/n6dU1xi5RpXLKhLPTGovVuKKxv285yKDD3t1c+zGFd UswPxT9Q==; From: Richard Sent In-Reply-To: (message from paul on Tue, 25 Jun 2024 00:49:07 +0200) Date: Wed, 26 Jun 2024 23:56:55 -0400 Message-ID: <87ikxvvy0o.fsf@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 4F3CA69E11 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.37 X-Spam-Score: -6.37 X-TUID: IeD3++8/lRsk Hi giacomo, > I think it would be nice to have an init action for the restic-guix > command shipped with the service and move there the logic for > initializing repositories. The service then could be adapted in a way > that it would call the restic-guix init before calling restic-guix > backup. Would you be interested in implementing this? I'll take a look at it and see what the code looks like. It might be a bit of effort to get that working cleanly while avoiding code dupe. For instance, setting RESTIC_PASSWORD(_COMMAND) in both init and backup program actions. Where do you think the appropriate place to check init? and run the init action is if it's no longer encapsulated in the backup action? A conditional in restic-backup-job->mcron-job before launching restic-guix backup? A one-shot shepherd service? The former will necessitate adding a job string to display when running $ herd schedule mcron. A downside of the latter is if the restic repository is deleted for one reason or another that backup job will fail until the system is rebooted, which isn't immediately obvious. Personally I prefer the mcron-job conditional. > At last, my use case for having a restic package field for each job is > to have some critical jobs that I don't want to touch running with > Guix's bootstrapped restic package and some personal jobs that I run > with a restic 0.16 binary package I have in my personal channel . I'm > not sure this warrants a field in each single job, but they are optional > anyway. Anyway I wouldn't consider this a blocker and if the Guix > project has some guidelines in this sense I'd say follow them. Ah, I see. To me this is where a per-job restic-override or similarly named field makes sense. This way we can have a default "global" restic package configured at a service level while still allowing individual jobs to use a custom restic package. I imagine this restic-override field would be a "maybe-file-like" either set to #f or a custom restic package. Thanks for the feedback! -- Take it easy, Richard Sent Making my computer weirder one commit at a time.