From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iP64Ac9ohmaGfwAAe85BDQ:P1 (envelope-from ) for ; Thu, 04 Jul 2024 09:18:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id iP64Ac9ohmaGfwAAe85BDQ (envelope-from ) for ; Thu, 04 Jul 2024 11:18:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GhEt8QwH; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720084686; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/6aayhsTyT5/nQNxstbffirMx2e9cq+ACHxm3MrAMTg=; b=bwl1ktvTtrPjpJfBTLtkM4U/UVYerBFpoUkD0wflT0oYq010cZnml1/Wf/Eyq5bbH5HuF/ rtXCBbUuO9V8kxauur7kfGhoSYPHAqPvpZXec4gRXClg+q8CLr8G9OuIFGcKs+ok+YygBE drh2b9VWcK0aaCKn279cdFYAuaoUlMTq4SvbRR4iYu/ZSG+FMCXP65wQNWQUkJ62N1nYl1 1Jdq/Eri56KUg5P7aoNM7cb8J85XHXd72nZVaLAPDR3oYFffPv72BkRN1PwMOPhkFaeFQg RAp9A8Eo5BUaKlnyQ2kEViG+O44wH241ZLV82rR9LAV1ay0O2K0Bv9cNNmPFCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GhEt8QwH; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720084686; a=rsa-sha256; cv=none; b=HMPg95cyCUx7iy3tEh87sUaa1J3WJT4+oqgqJVOn+gQR9LxOVl1mPcRz13Ekx3j5mQXYuv Uc1xtj/TPo++oNeLxoJaZ4Qr+ZmIly/98+J//eOgizLoFIZr/csKViiP5VK3xdPE9o7M5i 2H9IXwBGftAf638lyxERMkyFc7oVlhEzkkSIWEcH16DsKTvAlAH81OgMp4StJIl9DJXVy0 UEs3FUAIphY4OQhasUTCu7zr3K9BORbTCymWUsl3obo9kD9VjoxbPUjlrLmavaxnvG8MNJ O8vvaa3xopiQWDtx1vNouLv4EoS0HeNcQlipMLt42I7xJm8B7BOGe+IJn75RqQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83BCA74699 for ; Thu, 4 Jul 2024 11:18:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPIbK-0006G9-UV; Thu, 04 Jul 2024 05:18:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPIbH-0006Fd-QJ for guix-patches@gnu.org; Thu, 04 Jul 2024 05:17:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPIbH-0001UT-Hg for guix-patches@gnu.org; Thu, 04 Jul 2024 05:17:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPIbJ-00083I-QJ for guix-patches@gnu.org; Thu, 04 Jul 2024 05:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71038] [PATCH v2 2/2] guix: channels: Enable specifiying available builtin builders. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jul 2024 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 71038@debbugs.gnu.org Received: via spool by 71038-submit@debbugs.gnu.org id=B71038.172008464230903 (code B ref 71038); Thu, 04 Jul 2024 09:18:01 +0000 Received: (at 71038) by debbugs.gnu.org; 4 Jul 2024 09:17:22 +0000 Received: from localhost ([127.0.0.1]:41491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPIag-00082M-0P for submit@debbugs.gnu.org; Thu, 04 Jul 2024 05:17:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPIae-00082A-E7 for 71038@debbugs.gnu.org; Thu, 04 Jul 2024 05:17:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPIaW-0008Kk-P7; Thu, 04 Jul 2024 05:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/6aayhsTyT5/nQNxstbffirMx2e9cq+ACHxm3MrAMTg=; b=GhEt8QwHyoGb99cb0QOJ HvJWUg2R7wUES8pG2D63+WTioYOrfeAUmKV2TI//nNyog43CNCVOJrNEk3wpzHWyU5wFGFBzmVUM4 V9kDux1gNS5oeBRT3/1jPXjDIg6nxYPgyFVd/i1B6liwIVsl1M1fIabLIIeCZuSSKWRy6meDoowSz SFwz+zcm7HATrluLruS9tcAAB9rZm4i3LL3OdtTni6Mjf8A2udykjwyy+5XQ2byLQy1ad+CATUeNh BgKNVLpiio8h92+zAPqvB+6E3I1dOigYjHHlYwLq2NDzQN0rSf2wenkLxVtH7aUcBQ0CFMX0FVn9s eSSdrBomC1YoBw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <319c7822ef542dc412d55af616ecbeb86b005c8b.1719236626.git.mail@cbaines.net> (Christopher Baines's message of "Mon, 24 Jun 2024 14:43:46 +0100") References: <319c7822ef542dc412d55af616ecbeb86b005c8b.1719236626.git.mail@cbaines.net> Date: Thu, 04 Jul 2024 11:17:05 +0200 Message-ID: <87ikxl7bzi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.79 X-Migadu-Queue-Id: 83BCA74699 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.79 X-TUID: jf7aIeXzYSjw Christopher Baines skribis: > When computing channel instance derivations. > > This is useful when you want to generate compatible derivations that can = be > run with a daemon that potentially doesn't support builtin builders that = the > daemon you're using to generate the derivations has. > > I'm looking at this in particular because I want to use this in the data > service, since it provides substitutes for derivations, and since these c= an be > built on other machines, it's useful to control which builtin builders th= ey > depend on. > > Fixes: . > > * build-aux/build-self.scm (build-program): Accept > #:assume-available-builtin-builders and pass along to port->connection or > open-connection as approriate. > (build): Accept and pass on #:assume-available-builtin-builders. > * guix/channels.scm (build-from-source, build-channel-instance, > channel-instance-derivations, channel-instances->manifest, > channel-instances->derivation): Accept and pass on > #:assume-available-builtin-builders. > > Change-Id: I315c990de66c6f7dca25a859165a5568abe385ea I would have hoped we could avoid this, because it=E2=80=99s make tricky co= de a bit harder to read, but as you said, it=E2=80=99s a real issue that needs fixing: on build farms or for anyone using offloading and potentially not upgrading all the machines in lockstep. > + #:version proto > + #$@(if assume-available-buil= tin-builders > + #~(#:assume-available= -builtin-builders > + '(#$@assume-availa= ble-builtin-builders)) > + '())) Here (in =E2=80=98build-program=E2=80=99), we can assume we=E2=80=99re usin= g the current (guix store) module, so we can safely pass #:built-in-builders unconditionally. That=E2=80=99s it! The series LGTM with these changes. Thank you! :-)