* [bug#70085] [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning
@ 2024-03-30 1:10 Richard Sent
2024-08-08 18:04 ` [bug#70085] "Review" and gentle bump of 70085 Fabio Natali via Guix-patches via
0 siblings, 1 reply; 2+ messages in thread
From: Richard Sent @ 2024-03-30 1:10 UTC (permalink / raw)
To: 70085; +Cc: Richard Sent
* gnu/home/services.scm: Add end-of-text newline to warning printed by
on-first-login script when XDG_RUNTIME_DIR does not exist.
Change-Id: I3bfe2c415f6941fa9a2231ab2a0be53db965053f
---
Without this change, the prompt will be pushed to the side by the
warning message. Other warnings in the repo follow this convention, so
I assume this one should as well.
gnu/home/services.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/home/services.scm b/gnu/home/services.scm
index b69cd91203..39c9033ad6 100644
--- a/gnu/home/services.scm
+++ b/gnu/home/services.scm
@@ -445,7 +445,7 @@ (define (compute-on-first-login-script _ gexps)
(warning (G_ "XDG_RUNTIME_DIR doesn't exists, on-first-login script
won't execute anything. You can check if xdg runtime directory exists,
XDG_RUNTIME_DIR variable is set to appropriate value and manually execute the
-script by running '$HOME/.guix-home/on-first-login'"))))))))
+script by running '$HOME/.guix-home/on-first-login'~%"))))))))
(define (on-first-login-script-entry on-first-login)
"Return, as a monadic value, an entry for the on-first-login script
base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#70085] "Review" and gentle bump of 70085
2024-03-30 1:10 [bug#70085] [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning Richard Sent
@ 2024-08-08 18:04 ` Fabio Natali via Guix-patches via
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Natali via Guix-patches via @ 2024-08-08 18:04 UTC (permalink / raw)
To: 70085
Thanks Richard.
This is more of a bump rather than a review as the change itself is a
pretty obvious.
For what it's worth, I confirm I double-checked the change locally (as I
was accidentally experiencing the "XDG_RUNTIME_DIR doesn't exists"
warning).
All looks good, if someone with commit rights wants to give a final look
and push, that'd be cool.
Thanks, cheers, Fabio.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-08 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-30 1:10 [bug#70085] [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning Richard Sent
2024-08-08 18:04 ` [bug#70085] "Review" and gentle bump of 70085 Fabio Natali via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).