unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 73216@debbugs.gnu.org,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection.
Date: Fri, 13 Sep 2024 19:00:30 +0200	[thread overview]
Message-ID: <87ikuzlc9d.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <60bfe771a930daaec6fd53a2a63fae7fbdb6ac38.1726194205.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 13 Sep 2024 11:23:35 +0900")

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> +(define-public emacs-org-texlive-collection
> +  (package
> +    (inherit emacs-org)

I don't understand why this inherits from Emacs Org. You're basically
creating a specific TeX Live collection here. This should probably go to
"tex.scm".

> +    (name "emacs-org-texlive-collection")
> +    (source #f)
> +    (build-system trivial-build-system)
> +    (arguments (list #:builder #~(mkdir #$output)))
> +    (native-inputs '())
> +    (inputs '())
> +    (propagated-inputs
> +     (list texlive-amsmath
> +           texlive-capt-of
> +           texlive-graphics             ;for graphicx, rotating
> +           texlive-hyperref
> +           texlive-titling
> +           texlive-tools                ;for longtable
> +           texlive-ulem
> +           texlive-wrapfig
> +           texlive-scheme-small))      ;for amsfonts, fontspec, inputenc, etc.

This is much larger than what Org expects. The scheme above provides
XeTeX and Metapost, for example. I think it should be leaner if it
propagated provided texlive-collection-latexrecommended and a few
additional packages.

Note that texlive-tools, texlive-graphics and texlive-amsmath are
included already in texlive-scheme-small (and
texlive-collection-latexrecommended for that matter).

Out of my memories, I think it also needs texlive-soul.

> +    (synopsis "Basic TexLive packages for Org-mode LaTeX export")

Nitpick: TeX Live. Org mode.

> +    (description "This meta-package propagates the TexLive packages minimally
> +required by the Org-mode produced LaTeX output.")))

Ditto.

> +
>  (define-public emacs-org-contacts
>    ;; XXX: Upstream does not tag version bumps. Commit below matches latest
>    ;; version bump.
>
> base-commit: f5449685143be0805a8a9b54ddecee94e368c6e9

Regards,
-- 
Nicolas Goaziou






      parent reply	other threads:[~2024-09-13 17:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  2:23 [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection Maxim Cournoyer
2024-09-13  2:29 ` [bug#73216] [PATCH 2/2] gnu: emacs-org: Mention the emacs-org-texlive-collection in description Maxim Cournoyer
2024-09-13  6:26   ` Liliana Marie Prikler
2024-09-13 16:08     ` bug#73216: " Maxim Cournoyer
2024-09-13 17:02   ` [bug#73216] " Nicolas Goaziou via Guix-patches via
2024-09-13  6:26 ` [bug#73216] [PATCH 1/2] gnu: Add emacs-org-texlive-collection Liliana Marie Prikler
2024-09-13 14:16   ` Maxim Cournoyer
2024-09-13 14:30     ` Liliana Marie Prikler
2024-09-13 14:28   ` Maxim Cournoyer
2024-09-13 14:42     ` Liliana Marie Prikler
2024-09-13 17:00 ` Nicolas Goaziou via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikuzlc9d.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=73216@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).