* [bug#74570] [PATCH] gnu: xterm: Update to 395.
@ 2024-11-28 5:19 kiasoc5 via Guix-patches via
2024-11-29 9:59 ` Zheng Junjie
0 siblings, 1 reply; 5+ messages in thread
From: kiasoc5 via Guix-patches via @ 2024-11-28 5:19 UTC (permalink / raw)
To: 74570; +Cc: kiasoc5
* gnu/packages/xorg.scm (xterm): Update to 395.
Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
---
gnu/packages/xorg.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 554dc21ba7..470e8f1bc3 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -5969,7 +5969,7 @@ (define-public xmessage
(define-public xterm
(package
(name "xterm")
- (version "390")
+ (version "395")
(source
(origin
(method url-fetch)
@@ -5979,7 +5979,7 @@ (define-public xterm
(string-append "ftp://ftp.invisible-island.net/xterm/"
"xterm-" version ".tgz")))
(sha256
- (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
+ (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
(patches
(search-patches "xterm-370-explicit-xcursor.patch"))))
(build-system gnu-build-system)
base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
--
2.46.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#74570] [PATCH] gnu: xterm: Update to 395.
2024-11-28 5:19 [bug#74570] [PATCH] gnu: xterm: Update to 395 kiasoc5 via Guix-patches via
@ 2024-11-29 9:59 ` Zheng Junjie
2024-12-07 14:17 ` Maxim Cournoyer
0 siblings, 1 reply; 5+ messages in thread
From: Zheng Junjie @ 2024-11-29 9:59 UTC (permalink / raw)
To: 74570; +Cc: kiasoc5
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
kiasoc5 via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/xorg.scm (xterm): Update to 395.
>
> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
> ---
> gnu/packages/xorg.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index 554dc21ba7..470e8f1bc3 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -5969,7 +5969,7 @@ (define-public xmessage
> (define-public xterm
> (package
> (name "xterm")
> - (version "390")
> + (version "395")
> (source
> (origin
> (method url-fetch)
> @@ -5979,7 +5979,7 @@ (define-public xterm
> (string-append "ftp://ftp.invisible-island.net/xterm/"
> "xterm-" version ".tgz")))
> (sha256
> - (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
> + (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
> (patches
> (search-patches "xterm-370-explicit-xcursor.patch"))))
> (build-system gnu-build-system)
>
> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
Now the xvfb-run test depends on xterm, so we can't simply update xterm,
we might add a new xterm package and hide the original xterm for
xvfb-run only.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#74570] [PATCH] gnu: xterm: Update to 395.
2024-11-29 9:59 ` Zheng Junjie
@ 2024-12-07 14:17 ` Maxim Cournoyer
2024-12-08 23:28 ` kiasoc5 via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2024-12-07 14:17 UTC (permalink / raw)
To: Zheng Junjie; +Cc: 74570, kiasoc5
Hi Zheng,
Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
> kiasoc5 via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/xorg.scm (xterm): Update to 395.
>>
>> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
>> ---
>> gnu/packages/xorg.scm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
>> index 554dc21ba7..470e8f1bc3 100644
>> --- a/gnu/packages/xorg.scm
>> +++ b/gnu/packages/xorg.scm
>> @@ -5969,7 +5969,7 @@ (define-public xmessage
>> (define-public xterm
>> (package
>> (name "xterm")
>> - (version "390")
>> + (version "395")
>> (source
>> (origin
>> (method url-fetch)
>> @@ -5979,7 +5979,7 @@ (define-public xterm
>> (string-append "ftp://ftp.invisible-island.net/xterm/"
>> "xterm-" version ".tgz")))
>> (sha256
>> - (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
>> + (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
>> (patches
>> (search-patches "xterm-370-explicit-xcursor.patch"))))
>> (build-system gnu-build-system)
>>
>> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
>
> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
> we might add a new xterm package and hide the original xterm for
> xvfb-run only.
Yes, we could rename the current 'xterm' variable to xterm/pinned, make
it hidden, then proceed to add a new 'xterm' package which inherits from
it, at its latest version.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#74570] [PATCH] gnu: xterm: Update to 395.
2024-12-07 14:17 ` Maxim Cournoyer
@ 2024-12-08 23:28 ` kiasoc5 via Guix-patches via
2024-12-09 0:43 ` Maxim Cournoyer
0 siblings, 1 reply; 5+ messages in thread
From: kiasoc5 via Guix-patches via @ 2024-12-08 23:28 UTC (permalink / raw)
To: Maxim Cournoyer, Zheng Junjie; +Cc: 74570
On 12/7/24 09:17, Maxim Cournoyer wrote:
> Hi Zheng,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>
>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>> we might add a new xterm package and hide the original xterm for
>> xvfb-run only.
>
> Yes, we could rename the current 'xterm' variable to xterm/pinned, make
> it hidden, then proceed to add a new 'xterm' package which inherits from
> it, at its latest version.
>
I agree with making a separate xterm package for tests. Since naming is
one of the hardest things in computer science, how about naming the
pinned version 'xterm-for-tests' instead?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#74570] [PATCH] gnu: xterm: Update to 395.
2024-12-08 23:28 ` kiasoc5 via Guix-patches via
@ 2024-12-09 0:43 ` Maxim Cournoyer
0 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2024-12-09 0:43 UTC (permalink / raw)
To: kiasoc5; +Cc: 74570, Zheng Junjie
Hi,
kiasoc5 <kiasoc5@disroot.org> writes:
> On 12/7/24 09:17, Maxim Cournoyer wrote:
>> Hi Zheng,
>> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>>
>>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>>> we might add a new xterm package and hide the original xterm for
>>> xvfb-run only.
>> Yes, we could rename the current 'xterm' variable to xterm/pinned,
>> make
>> it hidden, then proceed to add a new 'xterm' package which inherits from
>> it, at its latest version.
>>
>
> I agree with making a separate xterm package for tests. Since naming
> is one of the hardest things in computer science, how about naming the
> pinned version 'xterm-for-tests' instead?
I don't have a strong preference, but note that in general I think
naming things based on what they *are*, rather than what they are *used*
for, is a better practice, as we can't reasonably foresee all future use
cases.
There is also a recent convention to use the '/pinned' suffix for
packages that shouldn't be updated often such as with our
git-minimal/pinned one [0]
[0] https://issues.guix.gnu.org/61078
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-09 0:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-28 5:19 [bug#74570] [PATCH] gnu: xterm: Update to 395 kiasoc5 via Guix-patches via
2024-11-29 9:59 ` Zheng Junjie
2024-12-07 14:17 ` Maxim Cournoyer
2024-12-08 23:28 ` kiasoc5 via Guix-patches via
2024-12-09 0:43 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).