unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: ashish.is@lostca.se
Cc: 73936@debbugs.gnu.org
Subject: [bug#73936] [PATCH] gnu: Add tuner.
Date: Mon, 30 Dec 2024 00:00:51 +0100	[thread overview]
Message-ID: <87ikr2nlgc.fsf@gnu.org> (raw)
In-Reply-To: <50be96afc2eac44f6c1ec910efe41a4b90000af6.1729533244.git.ashish.is@lostca.se> (ashish is's message of "Mon, 21 Oct 2024 19:54:05 +0200")

Hi,

ashish.is@lostca.se skribis:

> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/music.scm (tuner): New variable.
>
> Change-Id: I4ceb4b06069c460785b477cc017dc249f786dfa1

It fell through the cracks…

> +    (native-inputs
> +     `(("desktop-file-utils" ,desktop-file-utils)       ; update-desktop-database
> +       ("gettext-minimal" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin")                         ; glib-compile-schemas
> +       ; for org.gnome.system.proxy schema
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gtk:bin" ,gtk "bin")                           ; gtk-update-icon-cache
> +       ("pkg-config" ,pkg-config)
> +       ("vala" ,vala)))

Could you remove input labels (‘guix style -S inputs’)?

> +    (home-page "https://github.com/louis77/tuner")
> +    (synopsis "Application to discover and play internet radio stations")
> +    (description "A minimalist radio station player to discover and
> +listen to your favourite internet radio stations")

Could you turn the description into proper sentences, as per
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>?

Thanks in advance,
Ludo’.




  reply	other threads:[~2024-12-29 23:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 17:54 [bug#73936] [PATCH] gnu: Add tuner ashish.is--- via Guix-patches via
2024-12-29 23:00 ` Ludovic Courtès [this message]
2024-12-31 13:24   ` [bug#73936] [PATCH v2] " Ashish SHUKLA via Guix-patches via
2024-12-31 13:40     ` Zheng Junjie
2024-12-31 13:49       ` Ashish SHUKLA via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikr2nlgc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=73936@debbugs.gnu.org \
    --cc=ashish.is@lostca.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).