From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvS0v-0000T4-9U
	for guix-patches@gnu.org; Tue, 04 Apr 2017 13:13:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvS0s-0002EI-3Y
	for guix-patches@gnu.org; Tue, 04 Apr 2017 13:13:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34480)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cvS0s-0002E1-0q
	for guix-patches@gnu.org; Tue, 04 Apr 2017 13:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvS0r-0003IX-Ou
	for guix-patches@gnu.org; Tue, 04 Apr 2017 13:13:01 -0400
Subject: bug#26361: [PATCH 1/2] gnu: icecat: Use bundled ICU to avoid crashes.
Resent-Message-ID: <handler.26361.B26361.149132595112639@debbugs.gnu.org>
References: <87r3182rpu.fsf@lassieur.org>
	<20170404140808.22719-1-clement@lassieur.org>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <20170404140808.22719-1-clement@lassieur.org>
Date: Tue, 04 Apr 2017 19:12:26 +0200
Message-ID: <87h9242j2d.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 26361@debbugs.gnu.org

> gnu/packages/gnuzilla.scm (icecat)[arguments] <#:configure-flags>:
^
I forgot the * here.  I'll add it when I push.  Same with the other
patch.

> Temporarily comment out "--with-system-icu".

> ---
>  gnu/packages/gnuzilla.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 76a65f09e..adf72e41e 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
>  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
> +;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -509,7 +510,11 @@ standards.")
>                             "--with-system-jpeg"        ; must be libjpeg-turbo
>                             "--with-system-libevent"
>                             "--with-system-libvpx"
> -                           "--with-system-icu"
> +
> +                           ;; FIXME: It is preferable to build with system
> +                           ;; libraries, but this fixes crashes.
> +                           ;; "--with-system-icu"
> +
>                             "--with-system-nspr"
>                             "--with-system-nss"
>                             "--enable-system-pixman"